[PATCH] drm/i915/scaler: Fix condition for WA_14011503117

[Kandpal, Suraj]

> Subject: [PATCH] drm/i915/scaler: Fix condition for WA_14011503117
> 
> Add a check statement to check the scaler_id, if less than 0 then return.

The description should tell is why is does this need to be fixed, Also you are not adding a check statement rather modifying it.
So something like "scaler_state can never being null making the current condition for null check being useless. Remove that and while at it
Change the scaler_id to check if its less than 0"

Otherwise LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal at intel.com>

> 
> v2: Add scaler_id check [Jani]
> v3: Modify commit message[Suraj]
> 
> Fixes: 73309ed9d598 ("drm/i915/display: WA_14011503117")
> Signed-off-by: Nemesa Garg <nemesa.garg at intel.com>
> ---
>  drivers/gpu/drm/i915/display/skl_scaler.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c
> b/drivers/gpu/drm/i915/display/skl_scaler.c
> index cd7ebbeb9508..c6cccf170ff1 100644
> --- a/drivers/gpu/drm/i915/display/skl_scaler.c
> +++ b/drivers/gpu/drm/i915/display/skl_scaler.c
> @@ -960,7 +960,7 @@ void adl_scaler_ecc_unmask(const struct
> intel_crtc_state *crtc_state)
>  	const struct intel_crtc_scaler_state *scaler_state =
>  		&crtc_state->scaler_state;
> 
> -	if (!scaler_state && scaler_state->scaler_id == -1)
> +	if (scaler_state->scaler_id < 0)
>  		return;
> 
>  	intel_de_write_fw(display,
> --
> 2.25.1