[PATCH] drm/i915/audio: drop irq enabled check from LPE audio setup

[Jani Nikula]

On Thu, 14 Aug 2025, "Govindapillai, Vinod" <vinod.govindapillai at intel.com> wrote:
> On Fri, 2025-08-01 at 15:28 +0300, Jani Nikula wrote:
>> There shouldn't be anything requiring irqs to be enabled at the point of
>> LPE audio setup. Regardless, we've never hit the warning, as irqs are
>> always enabled at the time LPE audio is initialized. Drop the
>> superfluous warning, and the dependency on i915_drv.h.
>> 
>> Fix style a bit while at it.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>> ---
>>  drivers/gpu/drm/i915/display/intel_lpe_audio.c | 11 ++++-------
>>  1 file changed, 4 insertions(+), 7 deletions(-)
>> 
>
> Reviewed-by: Vinod Govindapillai <vinod.govindapillai at intel.com>

Thanks for the review, pushed to din.

BR,
Jani.

>
>> diff --git a/drivers/gpu/drm/i915/display/intel_lpe_audio.c
>> b/drivers/gpu/drm/i915/display/intel_lpe_audio.c
>> index 666148a14522..42284e9928f2 100644
>> --- a/drivers/gpu/drm/i915/display/intel_lpe_audio.c
>> +++ b/drivers/gpu/drm/i915/display/intel_lpe_audio.c
>> @@ -68,9 +68,9 @@
>>  #include <linux/platform_device.h>
>>  #include <linux/pm_runtime.h>
>>  
>> +#include <drm/drm_print.h>
>>  #include <drm/intel/intel_lpe_audio.h>
>>  
>> -#include "i915_drv.h"
>>  #include "i915_irq.h"
>>  #include "intel_audio_regs.h"
>>  #include "intel_de.h"
>> @@ -170,14 +170,11 @@ static struct irq_chip lpe_audio_irqchip = {
>>  
>>  static int lpe_audio_irq_init(struct intel_display *display)
>>  {
>> -	struct drm_i915_private *dev_priv = to_i915(display->drm);
>>  	int irq = display->audio.lpe.irq;
>>  
>> -	drm_WARN_ON(display->drm, !intel_irqs_enabled(dev_priv));
>> -	irq_set_chip_and_handler_name(irq,
>> -				&lpe_audio_irqchip,
>> -				handle_simple_irq,
>> -				"hdmi_lpe_audio_irq_handler");
>> +	irq_set_chip_and_handler_name(irq, &lpe_audio_irqchip,
>> +				      handle_simple_irq,
>> +				      "hdmi_lpe_audio_irq_handler");
>>  
>>  	return 0;
>>  }
>

-- 
Jani Nikula, Intel