[PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

[Andi Shyti]

Hi,

> > Please, next time, do not remove the mailing and the other folks
> > you cc'ed.
> > 
> > I'm adding back the mailing list and Daniele who has commented
> > before.
> 
> Thanks, I also found my previous response click on "reply", not the "reply
> all".

no worries, happens :-)

> > > > > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13454
> > > > > Fixes: 26705e20752a ("drm/i915: Support for GuC interrupts")
> > > > > Fixes: 54c52a841250 ("drm/i915/guc: Correctly handle GuC interrupts on Gen11")
> > > > > Fixes: 2ae096872a2c ("drm/i915/pxp: Implement PXP irq handler")
> > > > > Fixes: 3e7abf814193 ("drm/i915: Extract GT render power state management")
> > > > 
> > > > There is an issue here, each fixes is introduced in different
> > > > kernel versions and they can't be mixed all together as it would
> > > > be impossible to backport them to the stable brances.
> > > > 
> > > > E.g.:
> > > > Fixes: 3e7abf814193 ("drm/i915: Extract GT render power state management")
> > > > Cc: <stable at vger.kernel.org> # v5.5+
> > > > 
> > > > Fixes: 2ae096872a2c ("drm/i915/pxp: Implement PXP irq handler")
> > > > Cc: <stable at vger.kernel.org> # v5.16+
> > > > 
> > > > Fixes: 54c52a841250 ("drm/i915/guc: Correctly handle GuC interrupts on Gen11")
> > > > Cc: <stable at vger.kernel.org> # v5.3+
> > > > 
> > > > Fixes: 26705e20752a ("drm/i915: Support for GuC interrupts")
> > > > Cc: <stable at vger.kernel.org> # v4.10+
> > > > 
> > > > Could you please split this patch in the four different patches
> > > > that address the four different fixes?
> > > Sure, will split it in next rev.
> > 
> > First of all we need to understand if those Fixes are really
> > needed or not. Daniele in his review has pointed out that...
> I agree with Daniele, these fixes is not needed.

yeah, with such a low reproduction rate, if it's not a
catastrofic failure the Fixes: tag is not really needed and
therefore you don't need to split the patch anymore.

Still we need to understand whether this patch really fixes the
issue.

Thanks,
Andi