[PATCH xf86-video-intel 5/7] sna/video/sprite: Plug bo leak

Ville Syrjala ville.syrjala at linux.intel.com
Mon Feb 10 17:58:34 UTC 2025


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

Looks like we're leaking video->bo[index] if the entire
sprite gets clipped. Let's plug that leak.

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 src/sna/sna_video_sprite.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sna/sna_video_sprite.c b/src/sna/sna_video_sprite.c
index ce09d890af71..e2541e351b3f 100644
--- a/src/sna/sna_video_sprite.c
+++ b/src/sna/sna_video_sprite.c
@@ -548,7 +548,7 @@ off:
 				if (drmIoctl(video->sna->kgem.fd, LOCAL_IOCTL_MODE_SETPLANE, &s))
 					xf86DrvMsg(video->sna->scrn->scrnIndex, X_ERROR,
 						   "failed to disable plane\n");
-				video->bo[index] = NULL;
+				kgem_bo_replace(&sna->kgem, &video->bo[index], NULL);
 			}
 			continue;
 		}
-- 
2.45.3



More information about the Intel-gfx mailing list