[PATCH 09/12] drm/i915: Use REG_BIT() & co. for BDW+ EU/slice fuse bits

Andi Shyti andi.shyti at linux.intel.com
Mon Feb 24 10:17:58 UTC 2025


Hi Ville,

On Wed, Feb 12, 2025 at 01:19:37AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Convert the BDW+ EU/slice fuse bits to the modern REG_BIT()/etc.
> style.

using REG_BIT() and co. doesn't alway make it more readable. In
some of the cases below I would have preferred not to use it.

But on the other hand we keep consistency and bit operations are
not supposed to be easy-readable, anyway.

Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>

Thanks,
Andi


More information about the Intel-gfx mailing list