[PATCH v4 3/8] drm/i915/lobf: Add fixed refresh rate check in compute_config()

[Manna, Animesh]

> -----Original Message-----
> From: Nikula, Jani <jani.nikula at intel.com>
> Sent: Monday, February 24, 2025 4:16 PM
> To: Manna, Animesh <animesh.manna at intel.com>; intel-
> gfx at lists.freedesktop.org; intel-xe at lists.freedesktop.org
> Cc: Hogander, Jouni <jouni.hogander at intel.com>; B, Jeevan
> <jeevan.b at intel.com>; Manna, Animesh <animesh.manna at intel.com>
> Subject: Re: [PATCH v4 3/8] drm/i915/lobf: Add fixed refresh rate check in
> compute_config()
> 
> On Mon, 24 Feb 2025, Animesh Manna <animesh.manna at intel.com> wrote:
> > LOBF can be enabled with vrr fixed rate mode, so add check if vmin =
> > vmax = flipline in compute_config().
> >
> > Signed-off-by: Animesh Manna <animesh.manna at intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
> > b/drivers/gpu/drm/i915/display/intel_alpm.c
> > index d94c96ba46b1..1438e125cde1 100644
> > --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> > @@ -288,6 +288,10 @@ void intel_alpm_lobf_compute_config(struct
> intel_dp *intel_dp,
> >  	if (crtc_state->has_psr)
> >  		return;
> >
> > +	if (!(crtc_state->vrr.vmin == crtc_state->vrr.vmax &&
> > +	      crtc_state->vrr.vmin == crtc_state->vrr.flipline))
> 
> if vmin != vmax || vmin != flipline, right?

Ok.

Regards,
Animesh
> 
> 
> > +		return;
> > +
> >  	if (!(intel_alpm_aux_wake_supported(intel_dp) ||
> >  	      intel_alpm_aux_less_wake_supported(intel_dp)))
> >  		return;
> 
> --
> Jani Nikula, Intel