Regression on linux-next (next-20250221)

[Borah, Chaitanya Kumar]

Hello Bjorn,

Hope you are doing well. I am Chaitanya from the linux graphics team in Intel.

This mail is regarding a regression we are seeing in our CI runs[1] on linux-next repository.

Since the version next-20250221 [2], we are seeing that some of the machines in our CI are unable to connect through ssh (and therefore unable to participate).
Looking at the logs we see this.

`````````````````````````````````````````````````````````````````````````````````
[    5.838496] e1000e: Intel(R) PRO/1000 Network Driver
[    5.838515] e1000e: Copyright(c) 1999 - 2015 Intel Corporation.
[    5.838737] e1000e 0000:01:00.0: Disabling ASPM  L1
[    5.840055] e1000e 0000:01:00.0: probe with driver e1000e failed with error -12
`````````````````````````````````````````````````````````````````````````````````
After bisecting the tree, the following patch [3] seems to be the first "bad"
commit

`````````````````````````````````````````````````````````````````````````````````````````````````````````
commit 7d90d8d2bb1bfff8b33acbb6f815cba6f5250fad
Author: Bjorn Helgaas mailto:bhelgaas at google.com
Date:   Fri Feb 14 18:03:00 2025 -0600

    PCI: Avoid pointless capability searches

    Many of the save/restore functions in the pci_save_state() and
    pci_restore_state() paths depend on both a PCI capability of the device and
    a pci_cap_saved_state structure to hold the configuration data, and they
    skip the operation if either is missing.
`````````````````````````````````````````````````````````````````````````````````````````````````````````

We verified that if we revert the patch the issue is not seen.

Could you please check why the patch causes this regression and provide a fix if necessary?

Thank you.

Regards

Chaitanya

[1] https://intel-gfx-ci.01.org/tree/linux-next/combined-alt.html?
[2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20250221
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20250221&id=7d90d8d2bb1bfff8b33acbb6f815cba6f5250fad