[PATCH 1/3] drm/i915: Refactor eb_relocate_vma for clarity

[Andi Shyti]

Hi Sebastian,

...

> >>  out:
> >>  	reloc_cache_reset(&eb->reloc_cache, eb);
> >> -	return remain;
> >> +	return ret;
> >
> > now, this function is also returning a different value, not the
> > remaining bytes anymore but 0 on success and -error on failure.
> > Is this something you wanted?
> Function still returning the same value as before, but now we
> don't reuse variable. Regardless, the caller treats any return
> value the same. Still, the return value is either 0, an error,
> or an offset, just like before.

Even when this is true:

		} else if ((s64)offset < 0) {
			remain = (int)offset;
			goto out;

?

Andi