[PATCH] drm/i915/display: Change ret value type from int to long
Dan Carpenter
dan.carpenter at linaro.org
Thu Jul 17 17:18:38 UTC 2025
I did this but it's hard to know which places return LONG_MAX and
are problematic. This from an allyesconfig but on arm64 so it doesn't
warn about the i915 driver.
drivers/gpu/drm/tegra/submit.c:541 tegra_drm_ioctl_channel_submit() warn: save dma_fence_wait_timeout() returns to signed long
drivers/gpu/drm/etnaviv/etnaviv_gpu.c:1291 etnaviv_gpu_wait_fence_interruptible() warn: save dma_fence_wait_timeout() returns to signed long
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c:94 amdgpu_userq_wait_for_last_fence() warn: save dma_fence_wait_timeout() returns to signed long
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c:772 amdgpu_userq_wait_for_signal() warn: save dma_fence_wait_timeout() returns to signed long
drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c:828 vpe_ring_test_ib() warn: save dma_fence_wait_timeout() returns to signed long
drivers/gpu/drm/msm/msm_drv.c:687 wait_fence() warn: save dma_fence_wait_timeout() returns to signed long
The code in tegra_drm_ioctl_channel_submit() is reversed:
drivers/gpu/drm/tegra/submit.c
541 err = dma_fence_wait_timeout(fence, true, msecs_to_jiffies(10000));
542 dma_fence_put(fence);
543 if (err) {
^^^
This should be:
if (err <= 0) {
err = err ?: -ETIMEDOUT;
SUBMIT_ERR(context, "wait for syncobj_in timed out");
It's a bit of a headache to return 0 or negavite on failure.
regards,
dan carpenter
544 SUBMIT_ERR(context, "wait for syncobj_in timed out");
545 goto unlock;
546 }
More information about the Intel-gfx
mailing list