[PATCH v3 2/4] drm/i915: Replaced hardcoded value 4095 with PAGE_SIZE - 1
Andi Shyti
andi.shyti at linux.intel.com
Fri Jul 18 14:32:14 UTC 2025
On Fri, Jul 18, 2025 at 01:16:58PM +0200, Chris Wilson wrote:
> Quoting Sebastian Brzezinka (2025-07-18 12:28:11)
> > The value 4095 is intended to represent PAGE_SIZE - 1, as stated
> > in the commit that introduced this change:
> > commit 5f22cc0b134a ("drm/i915: Fix mismatch between misplaced
> > vma check and vma insert")
>
> No, that is exactly the misconception I wanted to avoid.
>
> The core kernel's system PAGE_SIZE is not necessarily the same as the
> paging boundary used by the GTT.
Too easy :-P Here is where I wanted to get. Page size might have
different meaning depending on the system.
A comment here to explain what the 4095 means would help to
better understand.
Andi
More information about the Intel-gfx
mailing list