[PATCH v4 1/3] drm/i915/psr: Do not disable Early Transport when enable_psr is set

Hogander, Jouni jouni.hogander at intel.com
Mon Jul 21 08:02:31 UTC 2025


On Tue, 2025-07-15 at 15:09 -0400, Rodrigo Vivi wrote:
> On Tue, Jul 15, 2025 at 01:55:07PM +0300, Jouni Högander wrote:
> > Current approach is that Early Transport is disabled in case
> > enable_psr
> > module parameter is set. Let's ignore enable_psr parameter when
> > choosing if
> > Early Transport can be used.
> > 
> > Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

Thank you Rodrigo for your review here. Whole set is now pushed to drm-
intel-next.

BR,

Jouni Högander

> 
> > ---
> >  drivers/gpu/drm/i915/display/intel_psr.c | 13 +------------
> >  1 file changed, 1 insertion(+), 12 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index ae9053919211..a2b5688f0c82 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -265,16 +265,6 @@ static bool psr2_global_enabled(struct
> > intel_dp *intel_dp)
> >  	}
> >  }
> >  
> > -static bool psr2_su_region_et_global_enabled(struct intel_dp
> > *intel_dp)
> > -{
> > -	struct intel_display *display =
> > to_intel_display(intel_dp);
> > -
> > -	if (display->params.enable_psr != -1)
> > -		return false;
> > -
> > -	return true;
> > -}
> > -
> >  static bool panel_replay_global_enabled(struct intel_dp *intel_dp)
> >  {
> >  	struct intel_display *display =
> > to_intel_display(intel_dp);
> > @@ -742,8 +732,7 @@ static bool psr2_su_region_et_valid(struct
> > intel_dp *intel_dp, bool panel_replay
> >  	return panel_replay ?
> >  		intel_dp-
> > >pr_dpcd[INTEL_PR_DPCD_INDEX(DP_PANEL_REPLAY_CAP_SUPPORT)] &
> >  		DP_PANEL_REPLAY_EARLY_TRANSPORT_SUPPORT :
> > -		intel_dp->psr_dpcd[0] ==
> > DP_PSR2_WITH_Y_COORD_ET_SUPPORTED &&
> > -		psr2_su_region_et_global_enabled(intel_dp);
> > +		intel_dp->psr_dpcd[0] ==
> > DP_PSR2_WITH_Y_COORD_ET_SUPPORTED;
> >  }
> >  
> >  static void _panel_replay_enable_sink(struct intel_dp *intel_dp,
> > -- 
> > 2.43.0
> > 



More information about the Intel-gfx mailing list