[PATCH] drm/i915/vblank: Change log from err to debug

Kandpal, Suraj suraj.kandpal at intel.com
Mon Jul 28 07:53:28 UTC 2025



> -----Original Message-----
> From: Golani, Mitulkumar Ajitkumar
> <mitulkumar.ajitkumar.golani at intel.com>
> Sent: Monday, July 28, 2025 11:47 AM
> To: Kandpal, Suraj <suraj.kandpal at intel.com>; intel-xe at lists.freedesktop.org;
> intel-gfx at lists.freedesktop.org
> Cc: Nautiyal, Ankit K <ankit.k.nautiyal at intel.com>; Kandpal, Suraj
> <suraj.kandpal at intel.com>
> Subject: RE: [PATCH] drm/i915/vblank: Change log from err to debug
> 
> 
> 
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of
> > Suraj Kandpal
> > Sent: 24 July 2025 16:00
> > To: intel-xe at lists.freedesktop.org; intel-gfx at lists.freedesktop.org
> > Cc: Nautiyal, Ankit K <ankit.k.nautiyal at intel.com>; Kandpal, Suraj
> > <suraj.kandpal at intel.com>
> > Subject: [PATCH] drm/i915/vblank: Change log from err to debug
> >
> > Let Potential update error just be a long instead of an big error we
> > already have
> 
> I think some typos to address in commit message, otherwise change is
> straight forward and looks good.
> 
> Please update before merge.
> 
> Code changes LGTM.
> Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.golani at intel.com>

Thanks for the review pushed to din with above mentioned changes

Regards,
Suraj Kandpal

> 
> > Atomic Update error log which shouts out if something really goes wrong.
> >
> > Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_vblank.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c
> > b/drivers/gpu/drm/i915/display/intel_vblank.c
> > index 70ba7aa26bf4..3e51deca0c21 100644
> > --- a/drivers/gpu/drm/i915/display/intel_vblank.c
> > +++ b/drivers/gpu/drm/i915/display/intel_vblank.c
> > @@ -724,9 +724,9 @@ int intel_vblank_evade(struct
> > intel_vblank_evade_ctx
> > *evade)
> >  			break;
> >
> >  		if (!timeout) {
> > -			drm_err(display->drm,
> > -				"Potential atomic update failure on pipe
> > %c\n",
> > -				pipe_name(crtc->pipe));
> > +			drm_dbg_kms(display->drm,
> > +				    "Potential atomic update failure on pipe
> > %c\n",
> > +				    pipe_name(crtc->pipe));
> >  			break;
> >  		}
> >
> > --
> > 2.34.1



More information about the Intel-gfx mailing list