[PATCH v4 3/8] bits: introduce fixed-type genmasks

Lucas De Marchi lucas.demarchi at intel.com
Thu Mar 6 14:48:47 UTC 2025


On Wed, Mar 05, 2025 at 11:38:19PM +0900, Vincent Mailhol wrote:
>On 05/03/2025 at 23:30, Andy Shevchenko wrote:
>> On Wed, Mar 05, 2025 at 10:00:15PM +0900, Vincent Mailhol via B4 Relay wrote:
>>> From: Yury Norov <yury.norov at gmail.com>
>>>
>>> Add __GENMASK_t() which generalizes __GENMASK() to support different
>>
>> Is it with double underscore? I do not see it.
>
>This is my mistake. In an earlier draft, it was __GENMASK_t(),
>meanwhile, I dropped the __ prefix but forget to update the patch
>description.
>
>> _t is used for typedef simple types. It's unfortunate to have it
>> in such a macro.
>
>Ack.
>
>> Perhaps T or TYPE will suffice. Or perhaps we want
>> __GENMASK_Uxx() here?
>
>If no objection, I have a preference for GENMASK_TYPE().

ack, GENMASK_TYPE() seems better.

thanks
Lucas De Marchi


More information about the Intel-gfx mailing list