[PATCH v3] i915/gt/selftests: Disable lrc_timestamp test
Mikolaj Wasiak
mikolaj.wasiak at intel.com
Fri Mar 14 14:48:56 UTC 2025
Hi,
On 2025-03-14 at 15:43:02 +0100, Andi Shyti wrote:
> >
> > Fixes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13697
> >
>
> Please don't make it as tag. Fixes has a specific meaning that
> means that the patch is fixing a bug introduced by a specific
> commit and it needs to be backported to stable kernels.
>
> You can use a discursive form, saying, e.g. that the issue has
> been reported here[*]. I can fix it, no need to resend.
>
Ok, I'll remember that.
> > + *
> > + * https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13697
>
> Please, no links in comments. If you want to refer to something
> specific in the link you can summarize it rather than adding the
> link.
>
> Is there anything you want to add from the link? Otherwise I am
> going to remove it.
>
No, I have nothing to add from the link, I just wasn't sure how to
properly document the change. I'll remember to not include any links in
future patches.
> > + */
> > + if (GRAPHICS_VER(gt->i915) == 12)
> > + return 0;
>
> yes, much cleaner than the first version. With the changes above:
>
> Reviewed-by: Andi Shyti <andi.shyti at kernel.org>
>
> Thanks,
> Andi
>
Thanks, Mikołaj
More information about the Intel-gfx
mailing list