[PATCH 15/18] drm/i915/dpll: Rename intel_unreference_dpll__crtc

[Kandpal, Suraj]

> -----Original Message-----
> From: Jani Nikula <jani.nikula at linux.intel.com>
> Sent: Friday, May 9, 2025 4:02 PM
> To: Kandpal, Suraj <suraj.kandpal at intel.com>; intel-xe at lists.freedesktop.org;
> intel-gfx at lists.freedesktop.org
> Cc: Nautiyal, Ankit K <ankit.k.nautiyal at intel.com>; Murthy, Arun R
> <arun.r.murthy at intel.com>; Kandpal, Suraj <suraj.kandpal at intel.com>
> Subject: Re: [PATCH 15/18] drm/i915/dpll: Rename intel_unreference_dpll__crtc
> 
> On Fri, 09 May 2025, Suraj Kandpal <suraj.kandpal at intel.com> wrote:
> > Rename intel_unreference_dpll_crtc to intel_dpll_unreference_crtc in
> > an effort to keep names of exported functions start with the filename.
> 
> That's a fine goal, but to me "intel dpll unreference crtc" means drop the crtc
> reference from dpll, not the other way round as it is...

Some suggestions for alternatives?

Intel_dpll_crtc_drop
Intel_dpll_crtc_put

I can update the intel_referece_dpll_crtc to intel_dpll_crtc_get

Regards,
Suraj Kandpal

> 
> > Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_dpll_mgr.c      | 6 +++---
> >  drivers/gpu/drm/i915/display/intel_dpll_mgr.h      | 2 +-
> >  drivers/gpu/drm/i915/display/intel_modeset_setup.c | 2 +-
> >  3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> > b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> > index d1399ab24d8c..c954515145a3 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> > @@ -458,7 +458,7 @@ intel_reference_dpll(struct intel_atomic_state
> > *state,  }
> >
> >  /**
> > - * intel_unreference_dpll_crtc - Drop a DPLL reference for a CRTC
> > + * intel_dpll_unreference_crtc - Drop a DPLL reference for a CRTC
> >   * @crtc: CRTC on which behalf the reference is dropped
> >   * @pll: DPLL for which the reference is dropped
> >   * @dpll_state: the DPLL atomic state in which the reference is
> > tracked @@ -466,7 +466,7 @@ intel_reference_dpll(struct intel_atomic_state
> *state,
> >   * Drop a reference for @pll tracking the end of use of it by @crtc.
> >   */
> >  void
> > -intel_unreference_dpll_crtc(const struct intel_crtc *crtc,
> > +intel_dpll_unreference_crtc(const struct intel_crtc *crtc,
> >  			    const struct intel_dpll *pll,
> >  			    struct intel_dpll_state *dpll_state)  { @@ -488,7
> +488,7 @@
> > static void intel_unreference_dpll(struct intel_atomic_state *state,
> >
> >  	dpll_state = intel_atomic_get_dpll_state(&state->base);
> >
> > -	intel_unreference_dpll_crtc(crtc, pll, &dpll_state[pll->index]);
> > +	intel_dpll_unreference_crtc(crtc, pll, &dpll_state[pll->index]);
> >  }
> >
> >  static void intel_put_dpll(struct intel_atomic_state *state, diff
> > --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> > b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> > index f497a9ec863d..8b596a96344f 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> > +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> > @@ -404,7 +404,7 @@ int intel_reserve_dplls(struct intel_atomic_state
> *state,
> >  			struct intel_encoder *encoder);
> >  void intel_release_dplls(struct intel_atomic_state *state,
> >  			 struct intel_crtc *crtc);
> > -void intel_unreference_dpll_crtc(const struct intel_crtc *crtc,
> > +void intel_dpll_unreference_crtc(const struct intel_crtc *crtc,
> >  				 const struct intel_dpll *pll,
> >  				 struct intel_dpll_state *shared_dpll_state);
> void
> > icl_set_active_port_dpll(struct intel_crtc_state *crtc_state, diff
> > --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > index ed4f305e0d3e..ee156cf2c5ce 100644
> > --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > @@ -93,7 +93,7 @@ static void intel_crtc_disable_noatomic_begin(struct
> intel_crtc *crtc,
> >  	crtc->base.enabled = false;
> >
> >  	if (crtc_state->intel_dpll)
> > -		intel_unreference_dpll_crtc(crtc,
> > +		intel_dpll_unreference_crtc(crtc,
> >  					    crtc_state->intel_dpll,
> >  					    &crtc_state->intel_dpll->state);  }
> 
> --
> Jani Nikula, Intel