✗ Fi.CI.CHECKPATCH: warning for drm/i915/ptl: Use everywhere the correct DDI port clock select mask

Patchwork patchwork at emeril.freedesktop.org
Mon May 12 17:32:17 UTC 2025


== Series Details ==

Series: drm/i915/ptl: Use everywhere the correct DDI port clock select mask
URL   : https://patchwork.freedesktop.org/series/148894/
State : warning

== Summary ==

Error: dim checkpatch failed
a41b8fdb6163 drm/i915/ptl: Use everywhere the correct DDI port clock select mask
-:66: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#66: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy.c:3172:
+					    intel_mtl_tbt_clock_select(display, crtc_state->port_clock));

-:112: WARNING:LONG_LINE: line length of 116 exceeds 100 columns
#112: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:198:
+							 _XE3_DDI_CLOCK_SELECT_MASK : _XELPDP_DDI_CLOCK_SELECT_MASK)

-:113: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#113: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:199:
+#define   XELPDP_DDI_CLOCK_SELECT_PREP(display, val)	(DISPLAY_VER(display) >= 30 ? \
+							 REG_FIELD_PREP(_XE3_DDI_CLOCK_SELECT_MASK, (val)) : \
+							 REG_FIELD_PREP(_XELPDP_DDI_CLOCK_SELECT_MASK, (val)))

-:114: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#114: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:200:
+							 REG_FIELD_PREP(_XE3_DDI_CLOCK_SELECT_MASK, (val)) : \

-:115: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#115: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:201:
+							 REG_FIELD_PREP(_XELPDP_DDI_CLOCK_SELECT_MASK, (val)))

-:116: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#116: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:202:
+#define   XELPDP_DDI_CLOCK_SELECT_GET(display, val)	(DISPLAY_VER(display) >= 30 ? \
+							 REG_FIELD_GET(_XE3_DDI_CLOCK_SELECT_MASK, (val)) : \
+							 REG_FIELD_GET(_XELPDP_DDI_CLOCK_SELECT_MASK, (val)))

-:117: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#117: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:203:
+							 REG_FIELD_GET(_XE3_DDI_CLOCK_SELECT_MASK, (val)) : \

-:118: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#118: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h:204:
+							 REG_FIELD_GET(_XELPDP_DDI_CLOCK_SELECT_MASK, (val)))

-:122: WARNING:MISSING_FIXES_TAG: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag?

total: 0 errors, 7 warnings, 2 checks, 91 lines checked




More information about the Intel-gfx mailing list