[PATCH 11/11] drm/i915: Disable updating of LUT values during vblank

[Shankar, Uma]

> -----Original Message-----
> From: Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>
> Sent: Tuesday, April 8, 2025 4:30 PM
> To: intel-xe at lists.freedesktop.org; intel-gfx at lists.freedesktop.org
> Cc: ville.syrjala at linux.intel.com; Shankar, Uma <uma.shankar at intel.com>;
> Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>; Manna, Animesh
> <animesh.manna at intel.com>
> Subject: [PATCH 11/11] drm/i915: Disable updating of LUT values during vblank
> 
> Do not schedule vblank worker for LUT update if the registers are double buffered
> 
> v2: Do not schedule the worker at all (Ville)

Looks Good to me.
Reviewed-by: Uma Shankar <uma.shankar at intel.com>

> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_crtc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c
> b/drivers/gpu/drm/i915/display/intel_crtc.c
> index 5b2603ef2ff7..fd6d52712462 100644
> --- a/drivers/gpu/drm/i915/display/intel_crtc.c
> +++ b/drivers/gpu/drm/i915/display/intel_crtc.c
> @@ -418,10 +418,13 @@ int intel_crtc_get_pipe_from_crtc_id_ioctl(struct
> drm_device *dev, void *data,
> 
>  static bool intel_crtc_needs_vblank_work(const struct intel_crtc_state
> *crtc_state)  {
> +	struct intel_display *display = to_intel_display(crtc_state);
> +
>  	return crtc_state->hw.active &&
>  		!crtc_state->preload_luts &&
>  		!intel_crtc_needs_modeset(crtc_state) &&
> -		intel_crtc_needs_color_update(crtc_state) &&
> +		(intel_crtc_needs_color_update(crtc_state) &&
> +		 !HAS_DOUBLE_BUFFERED_LUT(display)) &&
>  		!intel_color_uses_dsb(crtc_state) &&
>  		!crtc_state->use_dsb;
>  }
> --
> 2.25.1