<div dir="ltr">Hi<div><br></div><div>I've bisected back to this commit in the <span style="font-family:monospace">drm-intel-nightly</span> branch</div><div><br></div><div><span style="font-family:monospace">05a76d3d6ad1ee9f9814f88949cc9305fc165460 is the first bad commit
<br><span style="color:rgb(178,104,24)">commit 05a76d3d6ad1ee9f9814f88949cc9305fc165460</span>
<br>Author: Lyude <<a href="mailto:cpaul@redhat.com" target="_blank">cpaul@redhat.com</a>>
<br>Date: Wed Aug 17 15:55:57 2016 -0400
<br>
<br> drm/i915/skl: Ensure pipes with changed wms get added to the state
<br></span></div><div dir="ltr"><div><span style="font-family:monospace"> <br> If we're enabling a pipe, we'll need to modify the watermarks on all
<br> active planes. Since those planes won't be added to the state on
<br> their own, we need to add them ourselves.
<br> <br> Signed-off-by: Lyude <<a href="mailto:cpaul@redhat.com" target="_blank">cpaul@redhat.com</a>>
<br> Reviewed-by: Matt Roper <<a href="mailto:matthew.d.roper@intel.com" target="_blank">matthew.d.roper@intel.com</a>>
<br> Cc: <a href="mailto:stable@vger.kernel.org" target="_blank">stable@vger.kernel.org</a>
<br> Cc: Ville Syrjälä <<a href="mailto:ville.syrjala@linux.intel.com" target="_blank">ville.syrjala@linux.intel.com</a>>
<br> Cc: Daniel Vetter <<a href="mailto:daniel.vetter@intel.com" target="_blank">daniel.vetter@intel.com</a>>
<br> Cc: Radhakrishna Sripada <<a href="mailto:radhakrishna.sripada@intel.com" target="_blank">radhakrishna.sripada@intel.com</a>>
<br> Cc: Hans de Goede <<a href="mailto:hdegoede@redhat.com" target="_blank">hdegoede@redhat.com</a>>
<br></span></div></div><div dir="ltr"><div><span style="font-family:monospace"> Signed-off-by: Maarten Lankhorst <<a href="mailto:maarten.lankhorst@linux.intel.com" target="_blank">maarten.lankhorst@linux.intel.com</a>>
<br> Link: <a href="http://patchwork.freedesktop.org/patch/msgid/1471463761-26796-6-git-send-email-cpaul@redhat.com" target="_blank">http://patchwork.freedesktop.org/patch/msgid/1471463761-26796-6-git-send-email-cpaul@redhat.com</a><br></span></div><div><span style="font-family:monospace"><br></span></div><div>The symptoms I'm seeing look like tearing at the top of the screen and it's especially noticeable in Chrome - reverting this commit makes the issue go away</div><div><br></div><div>Let me know if you'd like me to raise a bug</div><div><br></div><div>Cheers</div></div><div dir="ltr"><div><br></div><div>Mike</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, 17 Aug 2016 at 20:56 Lyude <<a href="mailto:cpaul@redhat.com" target="_blank">cpaul@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If we're enabling a pipe, we'll need to modify the watermarks on all<br>
active planes. Since those planes won't be added to the state on<br>
their own, we need to add them ourselves.<br>
<br>
Signed-off-by: Lyude <<a href="mailto:cpaul@redhat.com" target="_blank">cpaul@redhat.com</a>><br>
Reviewed-by: Matt Roper <<a href="mailto:matthew.d.roper@intel.com" target="_blank">matthew.d.roper@intel.com</a>><br>
Cc: <a href="mailto:stable@vger.kernel.org" target="_blank">stable@vger.kernel.org</a><br>
Cc: Ville Syrjälä <<a href="mailto:ville.syrjala@linux.intel.com" target="_blank">ville.syrjala@linux.intel.com</a>><br>
Cc: Daniel Vetter <<a href="mailto:daniel.vetter@intel.com" target="_blank">daniel.vetter@intel.com</a>><br>
Cc: Radhakrishna Sripada <<a href="mailto:radhakrishna.sripada@intel.com" target="_blank">radhakrishna.sripada@intel.com</a>><br>
Cc: Hans de Goede <<a href="mailto:hdegoede@redhat.com" target="_blank">hdegoede@redhat.com</a>><br>
---<br>
drivers/gpu/drm/i915/intel_pm.c | 4 ++++<br>
1 file changed, 4 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c<br>
index 849f039..a3d24cb 100644<br>
--- a/drivers/gpu/drm/i915/intel_pm.c<br>
+++ b/drivers/gpu/drm/i915/intel_pm.c<br>
@@ -4117,6 +4117,10 @@ skl_compute_ddb(struct drm_atomic_state *state)<br>
ret = skl_allocate_pipe_ddb(cstate, ddb);<br>
if (ret)<br>
return ret;<br>
+<br>
+ ret = drm_atomic_add_affected_planes(state, &intel_crtc->base);<br>
+ if (ret)<br>
+ return ret;<br>
}<br>
<br>
return 0;<br>
--<br>
2.7.4<br>
<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org" target="_blank">dri-devel@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</blockquote></div></div>