<div dir="ltr"><div dir="ltr" class="gmail_msg">Hi<div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">This patch (in drm-next and drm-intel-nightly) stops my system from booting, I don't see any errors, just a black screen and a reboot after the kernel has been selected </div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">I have confirmed that reverting this patch gets those two branches working again</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Sorry to be the bearer of bad news - I'm guessing this is PRIME related</div></div><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Mike</div></div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Thu, 17 Nov 2016 at 07:42 Daniel Vetter <<a href="mailto:daniel@ffwll.ch" class="gmail_msg" target="_blank">daniel@ffwll.ch</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, Oct 28, 2016 at 10:10:50AM +0200, Daniel Vetter wrote:<br class="gmail_msg"> > Looking at the ioctl permission checks I noticed that it's impossible<br class="gmail_msg"> > to import gem buffers into a control nodes, and fd2handle/handle2fd<br class="gmail_msg"> > also don't work, so no joy with dma-bufs.<br class="gmail_msg"> ><br class="gmail_msg"> > The only way to do anything with a control node is by drawing stuff<br class="gmail_msg"> > into a dumb buffer and displaying that. I suspect control nodes are an<br class="gmail_msg"> > entirely unused thing, and a cursory check shows that there does not<br class="gmail_msg"> > seem to be any callers of drmOpenControl nor of the other drmOpen<br class="gmail_msg"> > functions using DRM_MODE_CONTROL.<br class="gmail_msg"> ><br class="gmail_msg"> > Since I don't like dead uabi, let's remove it. But since this would be<br class="gmail_msg"> > a really big change I think it's better to start out small by simply<br class="gmail_msg"> > not registering anything. We can garbage-collect the dead code later<br class="gmail_msg"> > on, once we're sure it's really not used anywhere.<br class="gmail_msg"> ><br class="gmail_msg"> > Signed-off-by: Daniel Vetter <<a href="mailto:daniel.vetter@intel.com" class="gmail_msg" target="_blank">daniel.vetter@intel.com</a>><br class="gmail_msg"> <br class="gmail_msg"> Applied with Dave's irc-ack to drm-misc.<br class="gmail_msg"> -Daniel<br class="gmail_msg"> <br class="gmail_msg"> > ---<br class="gmail_msg"> > drivers/gpu/drm/drm_drv.c | 6 ------<br class="gmail_msg"> > 1 file changed, 6 deletions(-)<br class="gmail_msg"> ><br class="gmail_msg"> > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c<br class="gmail_msg"> > index 6efdba4993fc..f085e28ffc6f 100644<br class="gmail_msg"> > --- a/drivers/gpu/drm/drm_drv.c<br class="gmail_msg"> > +++ b/drivers/gpu/drm/drm_drv.c<br class="gmail_msg"> > @@ -517,12 +517,6 @@ int drm_dev_init(struct drm_device *dev,<br class="gmail_msg"> > goto err_free;<br class="gmail_msg"> > }<br class="gmail_msg"> ><br class="gmail_msg"> > - if (drm_core_check_feature(dev, DRIVER_MODESET)) {<br class="gmail_msg"> > - ret = drm_minor_alloc(dev, DRM_MINOR_CONTROL);<br class="gmail_msg"> > - if (ret)<br class="gmail_msg"> > - goto err_minors;<br class="gmail_msg"> > - }<br class="gmail_msg"> > -<br class="gmail_msg"> > if (drm_core_check_feature(dev, DRIVER_RENDER)) {<br class="gmail_msg"> > ret = drm_minor_alloc(dev, DRM_MINOR_RENDER);<br class="gmail_msg"> > if (ret)<br class="gmail_msg"> > --<br class="gmail_msg"> > 2.10.1<br class="gmail_msg"> ><br class="gmail_msg"> <br class="gmail_msg"> --<br class="gmail_msg"> Daniel Vetter<br class="gmail_msg"> Software Engineer, Intel Corporation<br class="gmail_msg"> <a href="http://blog.ffwll.ch" rel="noreferrer" class="gmail_msg" target="_blank">http://blog.ffwll.ch</a><br class="gmail_msg"> _______________________________________________<br class="gmail_msg"> dri-devel mailing list<br class="gmail_msg"> <a href="mailto:dri-devel@lists.freedesktop.org" class="gmail_msg" target="_blank">dri-devel@lists.freedesktop.org</a><br class="gmail_msg"> <a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br class="gmail_msg"> </blockquote></div></div>