<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 6, 2016 at 6:57 PM, Tvrtko Ursulin <span dir="ltr"><<a href="mailto:tursulin@ursulin.net" target="_blank">tursulin@ursulin.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From: Tvrtko Ursulin <<a href="mailto:tvrtko.ursulin@intel.com">tvrtko.ursulin@intel.com</a>><br>
<br>
I wasn't here at the beginnings of DRM so I might have gotten this wrong,<br>
however the existance of DRM_NAME suggested to me that the intention was to<br>
allow individual drivers to override it and get appropriate prefixes in their<br>
log messages.<br>
<br>
I can't see that any driver is using it like that but I still thought it would<br>
be neat to do that. That way we could have our log messages look more<br>
obviously ours. For example after this series we have:<br>
<br>
[i915] Memory usable by graphics device = 4096M<br>
[i915] VT-d active for gfx access<br>
[i915] Replacing VGA console driver<br>
[i915] ACPI BIOS requests an excessive sleep of 20000 ms, using 1500 ms instead<br>
[i915] Finished loading DMC firmware i915/skl_dmc_ver1_26.bin (v1.26)<br>
[i915] Disabling framebuffer compression (FBC) to prevent screen flicker with VT-d enabled<br>
[i915] GuC firmware load skipped<br>
[i915] Initialized i915 1.6.0 20161205 for 0000:00:02.0 on minor 0<br>
[i915] DRM_I915_DEBUG enabled<br>
[i915] DRM_I915_DEBUG_GEM enabled<br>
[i915] RC6 on<br>
<br>
Previously all that was prefixed with "[drm]" which was OK but I think the<br>
above is even better.<br>
<br>
Also to consider is that recent drm_printk work has removed (it hardcoded)<br>
DRM_NAME from DRM_ERROR and DRM_DEBUG macros, while leaving it with the rest<br>
(DRM_INFO, NOTE and WARNING) creating a bit of a inconsistency.<br></blockquote><div><br></div><div>I wonder if I can maybe fold some of this idea into my related DRM_DEBUG [RFC] sent out recently:<br><a href="https://lists.freedesktop.org/archives/dri-devel/2016-December/126094.html">https://lists.freedesktop.org/archives/dri-devel/2016-December/126094.html</a><br><br></div><div>Instead of using DRM_NAME, I've experimented with updating my changes adding support for dynamic debug to add a prefix based on module_name(THIS_MODULE) for a similar result<br><br>One thing to consider here is that with the addition of dynamic debug support this prefix arguably becomes redundant because the dynamic_debug/control interface lets you choose to add a module name or function prefix to messages, e.g. like:<br></div><div><br></div><div>echo "module i915 +mfp" > dynamic_debug/control<br></div><div><br></div><div>I've ignored the redundancy because my change still allows enabling messages with the drm.drm_debug parameter and in that case the prefix is still useful.<br><br></div><div>Br,<br></div><div>- Robert<br></div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
This series also makes all the logging macros use drm_printk, but also<br>
makes DRM_NAME passed in from the macro wrappers in all cases. So drivers<br>
can override it regardless of the log level.<br>
<br>
And finally, the series also removes a bit of redundant data from the debug<br>
messages effectively converting this:<br>
<br>
[drm:edp_panel_off [i915]] Wait for panel power off time<br>
<br>
Into this:<br>
<br>
[edp_panel_off [i915]] Wait for panel power off time<br>
<br>
Which still has all the data in it.<br>
<br>
Tvrtko Ursulin (5):<br>
drm/i915: Give our log messages our name<br>
drm: Respect driver set DRM_NAME in drm_printk<br>
drm: Respect driver set DRM_NAME in drm_dev_printk<br>
drm: Use drm_printk for all logging macros<br>
drm: Do not log driver prefix in debug messages<br>
<br>
drivers/gpu/drm/drm_drv.c | 39 +++++++++++------<br>
drivers/gpu/drm/i915/i915_drv.<wbr>c | 3 +-<br>
include/drm/drmP.h | 94 ++++++++++++++++++++++++------<wbr>-----------<br>
include/drm/drm_drv.h | 11 ++---<br>
include/uapi/drm/i915_drm.h | 3 ++<br>
5 files changed, 92 insertions(+), 58 deletions(-)<br>
<span class="gmail-HOEnZb"><font color="#888888"><br>
--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
Intel-gfx mailing list<br>
<a href="mailto:Intel-gfx@lists.freedesktop.org">Intel-gfx@lists.freedesktop.<wbr>org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/intel-gfx" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/intel-gfx</a><br>
</font></span></blockquote></div><br></div></div>