<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 2/13/2017 6:03 PM, Chris Wilson wrote: </div> <blockquote cite="mid:20170213123329.GG30915@nuc-i3427.alporthouse.com" type="cite"> <pre wrap="">On Mon, Feb 13, 2017 at 02:25:29PM +0200, Joonas Lahtinen wrote: </pre> <blockquote type="cite"> <pre wrap="">On ma, 2017-02-13 at 11:02 +0000, Chris Wilson wrote: </pre> <blockquote type="cite"> <pre wrap="">On Mon, Feb 13, 2017 at 12:58:57PM +0200, Joonas Lahtinen wrote: </pre> <blockquote type="cite"> <pre wrap=""> On ma, 2017-02-13 at 12:14 +0530, Sagar Arun Kamble wrote: </pre> <blockquote type="cite"> <pre wrap=""> From: <a class="moz-txt-link-rfc2396E" href="mailto:sagar.a.kamble@intel.com">"sagar.a.kamble@intel.com"</a> <a class="moz-txt-link-rfc2396E" href="mailto:sagar.a.kamble@intel.com"><sagar.a.kamble@intel.com></a> With prefaulting extended to support >=2GB, i915 can handle relocation objects >=2GB. type conversion of length from int to unsigned long in access_ok was making the validation bail out with -EFAULT. Testcase: igt/gem_exec_reloc/wc-31 Cc: Daniel Vetter <a class="moz-txt-link-rfc2396E" href="mailto:daniel.vetter@ffwll.ch"><daniel.vetter@ffwll.ch></a> Cc: Chris Wilson <a class="moz-txt-link-rfc2396E" href="mailto:chris@chris-wilson.co.uk"><chris@chris-wilson.co.uk></a> Signed-off-by: Sagar Arun Kamble <a class="moz-txt-link-rfc2396E" href="mailto:sagar.a.kamble@intel.com"><sagar.a.kamble@intel.com></a> </pre> </blockquote> <pre wrap=""> With the correct "From:" and with "size_t" as type, this is; Reviewed-by: Joonas Lahtinen <a class="moz-txt-link-rfc2396E" href="mailto:joonas.lahtinen@linux.intel.com"><joonas.lahtinen@linux.intel.com></a> </pre> </blockquote> <pre wrap=""> My earlier comments still apply in that this is not how I fixed this years ago, and I still much prefer my fix. </pre> </blockquote> <pre wrap=""> Where are the earlier comments? I must have missed them. </pre> </blockquote> <pre wrap=""> I replied to the first time this patch landed in my inbox, which might have been trybotted. -Chris</pre> </blockquote> Chris, I thought those comments were about relocs_total and relocs_max values. Pasting below inputs from trybot. ------------ <pre class="content">The abi is limited to 32b max relocs. Please see <a class="moz-txt-link-freetext" href="https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=prescheduler&id=bcf3bca07f21a4c0c754ccecca81228c28437906">https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=prescheduler&id=bcf3bca07f21a4c0c754ccecca81228c28437906</a> (a patch that is years overdue) in which this just evaporates. -Chris --------- </pre> <blockquote cite="mid:20170213123329.GG30915@nuc-i3427.alporthouse.com" type="cite"> <pre wrap=""> </pre> </blockquote> </body> </html>