<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On Friday 04 August 2017 04:04 PM,
Lionel Landwerlin wrote:<br>
</div>
<blockquote
cite="mid:99e06ee3-ece3-90d6-fd54-ea6789d991f9@intel.com"
type="cite">On 04/08/17 11:22, Arvind Yadav wrote:
<br>
<blockquote type="cite">Hi Lionel,
<br>
<br>
<br>
On Friday 04 August 2017 02:33 PM, Lionel Landwerlin wrote:
<br>
<blockquote type="cite">Hi Arwind,
<br>
<br>
These files were generated by a script maintained in this
repository :
<a class="moz-txt-link-freetext" href="https://github.com/rib/gputop/blob/master/scripts/i915-perf-kernelgen.py">https://github.com/rib/gputop/blob/master/scripts/i915-perf-kernelgen.py</a>
<br>
It would best to update this script first to make sure future
platforms get the fixes too.
<br>
<br>
Some changes have just been merged, deleted most configs but
the test ones.
<br>
You'll need to update your series.
<br>
<br>
</blockquote>
I have done the changes. Please review it. :) Shared patch is
0001-i915-perf-kernelgen.py-constify-attribute_group-stru.patch.
<br>
</blockquote>
<br>
Hm... Where is it? (I can't see it on the mailing list nor
attached)
<br>
The best would be to submit a PR on the github project directly.
<br>
<br>
</blockquote>
I have push directly on github project. I have send patch to you. Is
there any different way to send mail.?<br>
Changes are looks like this. <br>
<br>
---<br>
scripts/i915-perf-kernelgen.py | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/scripts/i915-perf-kernelgen.
<div id=":a8n" class="a3s aXjCH m15dacc19b02f3ee6"><wbr>py
b/scripts/i915-perf-kernelgen.<wbr>py<br>
index 7178f47..7633624 100755<br>
--- a/scripts/i915-perf-kernelgen.<wbr>py<br>
+++ b/scripts/i915-perf-kernelgen.<wbr>py<br>
@@ -382,7 +382,7 @@ def output_sysfs_code(sets):<br>
c("};")<br>
<br>
c("\n")<br>
- c("static struct attribute_group group_" + perf_name_lc +
" = {")<br>
+ c("static const struct attribute_group group_" +
perf_name_lc + " = {")<br>
c.indent(8)<br>
c(".name = \"" + metric_set['guid'] + "\",")<br>
c(".attrs = attrs_" + perf_name_lc + ",")</div>
<br>
---<br>
<blockquote
cite="mid:99e06ee3-ece3-90d6-fd54-ea6789d991f9@intel.com"
type="cite">
<blockquote type="cite">
<br>
<blockquote type="cite">Otherwise it looks like a good change.
<br>
<br>
Thanks,
<br>
<br>
-
<br>
Lionel
<br>
<br>
On 04/08/17 06:03, Arvind Yadav wrote:
<br>
<blockquote type="cite">attribute_group are not supposed to
change at runtime. All functions
<br>
working with attribute_group provided by
<linux/sysfs.h> work with
<br>
const attribute_group. So mark the non-const structs as
const.
<br>
<br>
Arvind Yadav (11):
<br>
[PATCH 01/11] drm: i915: i915_oa_kblgt2: constify
attribute_group structures.
<br>
[PATCH 02/11] drm: i915: i915_oa_bdw: constify
attribute_group structures.
<br>
[PATCH 03/11] drm: i915: i915_oa_bxt: constify
attribute_group structures.
<br>
[PATCH 04/11] drm: i915: i915_oa_chv: constify
attribute_group structures.
<br>
[PATCH 05/11] drm: i915: i915_oa_glk: constify
attribute_group structures.
<br>
[PATCH 06/11] drm: i915: i915_oa_hsw: constify
attribute_group structures.
<br>
[PATCH 07/11] drm: i915: i915_oa_kblgt3: constify
attribute_group structures.
<br>
[PATCH 08/11] drm: i915: i915_oa_sklgt2: constify
attribute_group structures.
<br>
[PATCH 09/11] drm: i915: i915_oa_sklgt3: constify
attribute_group structures.
<br>
[PATCH 10/11] drm: i915: i915_oa_sklgt4: constify
attribute_group structures.
<br>
[PATCH 11/11] drm: i915: i915_sysfs: constify
attribute_group structures.
<br>
<br>
drivers/gpu/drm/i915/i915_oa_bdw.c | 44
+++++++++++++++++------------------
<br>
drivers/gpu/drm/i915/i915_oa_bxt.c | 30
++++++++++++------------
<br>
drivers/gpu/drm/i915/i915_oa_chv.c | 28
+++++++++++-----------
<br>
drivers/gpu/drm/i915/i915_oa_glk.c | 30
++++++++++++------------
<br>
drivers/gpu/drm/i915/i915_oa_hsw.c | 12 +++++-----
<br>
drivers/gpu/drm/i915/i915_oa_kblgt2.c | 36
++++++++++++++--------------
<br>
drivers/gpu/drm/i915/i915_oa_kblgt3.c | 36
++++++++++++++--------------
<br>
drivers/gpu/drm/i915/i915_oa_sklgt2.c | 36
++++++++++++++--------------
<br>
drivers/gpu/drm/i915/i915_oa_sklgt3.c | 36
++++++++++++++--------------
<br>
drivers/gpu/drm/i915/i915_oa_sklgt4.c | 36
++++++++++++++--------------
<br>
drivers/gpu/drm/i915/i915_sysfs.c | 6 ++---
<br>
11 files changed, 165 insertions(+), 165 deletions(-)
<br>
<br>
</blockquote>
<br>
</blockquote>
~arvind
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>