<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <div>Juvenile no 00 <div><br> </div> <div><br> </div> <div>-------- Original message --------</div> <div>From: "Wang, Zhi A" <zhi.a.wang@intel.com> </div> <div>Date: 9/14/17 8:03 PM (GMT-08:00) </div> <div>To: Chris Wilson <chris@chris-wilson.co.uk>, "Vivi, Rodrigo" <rodrigo.vivi@intel.com> </div> <div>Cc: intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, joonas.lahtinen@linux.intel.com, zhenyuw@linux.intel.com, "Widawsky, Benjamin" <benjamin.widawsky@intel.com> </div> <div>Subject: RE: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get() </div> <div><br> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">Sorry for the trouble. It's because we have 4 different entries with different attributes and every time we match an entry by cache attribute, we got a perfect match...<br> <br> -----Original Message-----<br> From: Chris Wilson [<a href="mailto:chris@chris-wilson.co.uk">mailto:chris@chris-wilson.co.uk</a>] <br> Sent: Thursday, September 14, 2017 9:41 PM<br> To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Wang, Zhi A <zhi.a.wang@intel.com><br> Cc: intel-gfx@lists.freedesktop.org; intel-gvt-dev@lists.freedesktop.org; joonas.lahtinen@linux.intel.com; zhenyuw@linux.intel.com; Widawsky, Benjamin <benjamin.widawsky@intel.com><br> Subject: Re: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()<br> <br> Quoting Rodrigo Vivi (2017-09-14 18:36:49)<br> > <br> > well, I wouldn't call this as a typo.<br> > This is a logic fix and deserves a better subject a proper commit <br> > message an also fixes tag:<br> <br> It should work either way, just the bug doesn't allow reuse.<br> <br> The question to ask is why didn't the selftest pick this up? It passes on bdw...<br> -Chris<br> </div> </span></font> </body> </html>