<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.emailquote, li.emailquote, div.emailquote
{mso-style-name:emailquote;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:1.0pt;
border:none;
padding:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Oops. So it’s like we have to create some entries with same cache attributes before perfect match test case.
<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Widawsky, Benjamin
<br>
<b>Sent:</b> Friday, September 15, 2017 8:02 AM<br>
<b>To:</b> Wang, Zhi A <zhi.a.wang@intel.com>; Chris Wilson <chris@chris-wilson.co.uk>; Vivi, Rodrigo <rodrigo.vivi@intel.com><br>
<b>Cc:</b> intel-gfx@lists.freedesktop.org; intel-gvt-dev@lists.freedesktop.org; joonas.lahtinen@linux.intel.com; zhenyuw@linux.intel.com<br>
<b>Subject:</b> Re: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Juvenile no 00<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">-------- Original message --------<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">From: "Wang, Zhi A" <<a href="mailto:zhi.a.wang@intel.com">zhi.a.wang@intel.com</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Date: 9/14/17 8:03 PM (GMT-08:00) <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">To: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>, "Vivi, Rodrigo" <<a href="mailto:rodrigo.vivi@intel.com">rodrigo.vivi@intel.com</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Cc: <a href="mailto:intel-gfx@lists.freedesktop.org">intel-gfx@lists.freedesktop.org</a>,
<a href="mailto:intel-gvt-dev@lists.freedesktop.org">intel-gvt-dev@lists.freedesktop.org</a>,
<a href="mailto:joonas.lahtinen@linux.intel.com">joonas.lahtinen@linux.intel.com</a>,
<a href="mailto:zhenyuw@linux.intel.com">zhenyuw@linux.intel.com</a>, "Widawsky, Benjamin" <<a href="mailto:benjamin.widawsky@intel.com">benjamin.widawsky@intel.com</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Subject: RE: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt">Sorry for the trouble. It's because we have 4 different entries with different attributes and every time we match an entry by cache attribute, we got a perfect match...<br>
<br>
-----Original Message-----<br>
From: Chris Wilson [<a href="mailto:chris@chris-wilson.co.uk">mailto:chris@chris-wilson.co.uk</a>]
<br>
Sent: Thursday, September 14, 2017 9:41 PM<br>
To: Vivi, Rodrigo <<a href="mailto:rodrigo.vivi@intel.com">rodrigo.vivi@intel.com</a>>; Wang, Zhi A <<a href="mailto:zhi.a.wang@intel.com">zhi.a.wang@intel.com</a>><br>
Cc: <a href="mailto:intel-gfx@lists.freedesktop.org">intel-gfx@lists.freedesktop.org</a>;
<a href="mailto:intel-gvt-dev@lists.freedesktop.org">intel-gvt-dev@lists.freedesktop.org</a>;
<a href="mailto:joonas.lahtinen@linux.intel.com">joonas.lahtinen@linux.intel.com</a>;
<a href="mailto:zhenyuw@linux.intel.com">zhenyuw@linux.intel.com</a>; Widawsky, Benjamin <<a href="mailto:benjamin.widawsky@intel.com">benjamin.widawsky@intel.com</a>><br>
Subject: Re: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()<br>
<br>
Quoting Rodrigo Vivi (2017-09-14 18:36:49)<br>
> <br>
> well, I wouldn't call this as a typo.<br>
> This is a logic fix and deserves a better subject a proper commit <br>
> message an also fixes tag:<br>
<br>
It should work either way, just the bug doesn't allow reuse.<br>
<br>
The question to ask is why didn't the selftest pick this up? It passes on bdw...<br>
-Chris<o:p></o:p></span></p>
</div>
</div>
</body>
</html>