<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 26, 2017 at 10:37 AM, Puthikorn Voravootivat <span dir="ltr"><<a href="mailto:puthik@chromium.org" target="_blank" class="gmail-cremed gmail-cremed cremed">puthik@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On Mon, Sep 25, 2017 at 10:11 PM, Daniel Vetter <span dir="ltr"><<a href="mailto:daniel@ffwll.ch" class="gmail-m_6404433486723116070cremed gmail-cremed gmail-cremed cremed" target="_blank">daniel@ffwll.ch</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>On Thu, Sep 21, 2017 at 07:42:07AM -0700, Rodrigo Vivi wrote:<br> > On Wed, Sep 20, 2017 at 02:32:34PM +0000, vathsala nagaraju wrote:<br> > > Add defines for dpcd register 2009 (synchronization latency<br> > > in sink).<br> > ><br> > > Cc: Rodrigo Vivi <<a href="mailto:rodrigo.vivi@intel.com" class="gmail-m_6404433486723116070cremed gmail-cremed gmail-cremed cremed" target="_blank">rodrigo.vivi@intel.com</a>><br> > > CC: Puthikorn Voravootivat <<a href="mailto:puthik@chromium.org" class="gmail-m_6404433486723116070cremed gmail-cremed gmail-cremed cremed" target="_blank">puthik@chromium.org</a>><br> > > Signed-off-by: Vathsala Nagaraju <<a href="mailto:vathsala.nagaraju@intel.com" class="gmail-m_6404433486723116070cremed gmail-cremed gmail-cremed cremed" target="_blank">vathsala.nagaraju@intel.com</a>><br> ><br> > I keep forgetting to update my eDP spec 1.4 to this 1.4b...<br> <br> </span>Maybe the patch should then make this clear, by annotating it with<br> /* eDP 1.4b */ That's missing, which isn't all that great really, since it<br> makes specs hunts like yours necessary.<br> <br></blockquote></span><div>It's actually in eDP 1.4 spec, table 5-6 page 86</div></div></div></div></blockquote><div>Copy and paste the wrong one.</div><div>0x2009 is actually in eDP 1.4 spec, Table 6-7: DPCD – Sink Device PSR Status Field page 124</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="gmail-h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Please fix up before applying.<br> -Daniel<br> <span>><br> ><br> > Reviewed-by: Rodrigo Vivi <<a href="mailto:rodrigo.vivi@intel.com" class="gmail-m_6404433486723116070cremed gmail-cremed gmail-cremed cremed" target="_blank">rodrigo.vivi@intel.com</a>><br> ><br> ><br> ><br> > > ---<br> > > include/drm/drm_dp_helper.h | 3 +++<br> > > 1 file changed, 3 insertions(+)<br> > ><br> > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h<br> > > index 11c39f1..846004e6 100644<br> > > --- a/include/drm/drm_dp_helper.h<br> > > +++ b/include/drm/drm_dp_helper.h<br> > > @@ -735,6 +735,9 @@<br> > > # define DP_PSR_SINK_INTERNAL_ERROR 7<br> > > # define DP_PSR_SINK_STATE_MASK 0x07<br> > ><br> > > +#define DP_SINK_SYNCHRONIZATION_LATENC<wbr>Y 0x2009<br> > > +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf<br> > > +<br> > > #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */<br> > > # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0)<br> > ><br> > > --<br> > > 1.9.1<br> > ><br> </span>> ______________________________<wbr>_________________<br> > dri-devel mailing list<br> > <a href="mailto:dri-devel@lists.freedesktop.org" class="gmail-m_6404433486723116070cremed gmail-cremed gmail-cremed cremed" target="_blank">dri-devel@lists.freedesktop.or<wbr>g</a><br> > <a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" class="gmail-m_6404433486723116070cremed gmail-cremed gmail-cremed cremed" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/dri-devel</a><br> <span class="gmail-m_6404433486723116070HOEnZb"><font color="#888888"><br> --<br> Daniel Vetter<br> Software Engineer, Intel Corporation<br> <a href="http://blog.ffwll.ch" rel="noreferrer" class="gmail-m_6404433486723116070cremed gmail-cremed gmail-cremed cremed" target="_blank">http://blog.ffwll.ch</a><br> </font></span></blockquote></div></div></div><br></div></div> </blockquote></div><br></div></div>