<div dir="ltr">On 9 January 2018 at 05:11, Petri Latvala <span dir="ltr"><<a href="mailto:petri.latvala@intel.com" target="_blank">petri.latvala@intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Commit 98c64b33a793 ("lib/igt_kms: Drop all stale events on first<br>
commit.") added a use of poll() to igt_kms.c, but that file only<br>
includes poll.h when HAVE_UDEV is defined. Move the include outside<br>
the UDEV conditional.<br>
<br>
Fixes: 98c64b33a793 ("lib/igt_kms: Drop all stale events on first commit.")<br>
Signed-off-by: Petri Latvala <<a href="mailto:petri.latvala@intel.com">petri.latvala@intel.com</a>><br>
Cc: Maarten Lankhorst <<a href="mailto:maarten.lankhorst@linux.intel.com">maarten.lankhorst@linux.<wbr>intel.com</a>><br>
Cc: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>><br></blockquote><div><br></div><div>I have also hit this issue, and spun up locally the equivalent patch fix, so also gets my:</div><div><br></div><div><span class="gmail-m_-3796206122752663915gmail-il"><span class="gmail-il">Reviewed</span></span>-<span class="gmail-m_-3796206122752663915gmail-il"><span class="gmail-il">by</span></span>: <span class="gmail-m_-3796206122752663915gmail-il"><span class="gmail-il">Rhys</span></span> Kidd <<a href="mailto:rhyskidd@gmail.com" target="_blank">rhyskidd@gmail.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
 lib/igt_kms.c | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/lib/igt_kms.c b/lib/igt_kms.c<br>
index ec3b7167..069752ec 100644<br>
--- a/lib/igt_kms.c<br>
+++ b/lib/igt_kms.c<br>
@@ -40,8 +40,8 @@<br>
 #endif<br>
 #ifdef HAVE_UDEV<br>
 #include <libudev.h><br>
-#include <poll.h><br>
 #endif<br>
+#include <poll.h><br>
 #include <errno.h><br>
 #include <time.h><br>
<span class="gmail-HOEnZb"><font color="#888888"><br>
--<br>
2.14.1<br>
<br>
______________________________<wbr>_________________<br>
Intel-gfx mailing list<br>
<a href="mailto:Intel-gfx@lists.freedesktop.org">Intel-gfx@lists.freedesktop.<wbr>org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/intel-gfx" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/intel-gfx</a><br>
</font></span></blockquote></div><br></div></div>