<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body bgcolor="white" lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <o:p> </o:p> <a name="_MailEndCompose"><o:p> </o:p></a> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> <a name="_____replyseparator"></a>From: Sharma, Shashank Sent: Thursday, February 8, 2018 12:17 PM To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org Cc: maarten.lankhorst@linux.intel.com; Kamath, Sunil <sunil.kamath@intel.com>; Shankar, Uma <uma.shankar@intel.com>; Kumar, Mahesh1 <mahesh1.kumar@intel.com> Subject: Re: [PATCH 03/16] drm/i915/skl+: add NV12 in skl_format_to_fourcc<o:p></o:p> </div> </div> <o:p> </o:p> Regards<o:p></o:p> Shashank<o:p></o:p> <o:p> </o:p> <div> On 2/8/2018 10:02 AM, Sharma, Shashank wrote:<o:p></o:p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> On 2/8/2018 8:50 AM, Srinivas, Vidya wrote: <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> -----Original Message----- From: Sharma, Shashank Sent: Wednesday, February 7, 2018 9:22 PM To: Srinivas, Vidya <a href="mailto:vidya.srinivas@intel.com"><vidya.srinivas@intel.com></a>; intel- <a href="mailto:gfx@lists.freedesktop.org">gfx@lists.freedesktop.org</a> Cc: <a href="mailto:maarten.lankhorst@linux.intel.com">maarten.lankhorst@linux.intel.com</a>; Kamath, Sunil <a href="mailto:sunil.kamath@intel.com"><sunil.kamath@intel.com></a>; Shankar, Uma <a href="mailto:uma.shankar@intel.com"><uma.shankar@intel.com></a>; Kumar, Mahesh1 <a href="mailto:mahesh1.kumar@intel.com"><mahesh1.kumar@intel.com></a> Subject: Re: [PATCH 03/16] drm/i915/skl+: add NV12 in skl_format_to_fourcc Regards Shashank On 2/6/2018 6:28 PM, Vidya Srinivas wrote: <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> From: Mahesh Kumar <a href="mailto:mahesh1.kumar@intel.com"> <mahesh1.kumar@intel.com></a> Add support of recognizing DRM_FORMAT_NV12 from plane_format <o:p></o:p> </blockquote> register <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> value. Signed-off-by: Mahesh Kumar <a href="mailto:mahesh1.kumar@intel.com"><mahesh1.kumar@intel.com></a> --- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 60ba5bb..e3a6a7f 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -2626,6 +2626,8 @@ static int skl_format_to_fourcc(int format, bool <o:p></o:p> </blockquote> rgb_order, bool alpha) <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> switch (format) { case PLANE_CTL_FORMAT_RGB_565: return DRM_FORMAT_RGB565; + case PLANE_CTL_FORMAT_NV12: + return DRM_FORMAT_NV12; <o:p></o:p> </blockquote> I dont think this is correct, the case PLANE_CTL_FORMAT_NV12 is defined as (1 << 24) but when I check bspec definition, 24th bit is set for P010/12/16 formats. AFAIK NV12 is 8 bit format whereas P0xx formats are 10/12/16 bit formats (they both are YCBCR 4:2:0 of course). This means we have mixed NV12 format with P0xx formats. When I checked the definition of DRM_FORMAT_NV12, I am not sure if that's intended for this. Ville, I saw that the DRM_FORMAT_NV12 definition was added by you, can you please comment if this is the right usage ? <o:p></o:p> </blockquote> Upto Gen10 24-27 bits of PLANE_CTL will be used for format. ICL onwards 23rd bit is also used. PLANE_CTL_FORMAT_MASK has been defined in i915_reg.h and mapping will be same if 23rd bit is 0. For NV12, 1<< 24 thus holds good for all Gen. <o:p></o:p> </blockquote> That's not my point. What I want to say is, as per bspec (1 << 24) is for P010/P012/P016 formats, not NV12. NV12 is 8 bit YCBCR 4:2:0 format whereas P010/012/016 are 10,12 and 16 bit YCBCR 4:2:0 formats. So I was not sure if that should be called NV12 and hence I was not sure if we should return DRM_FORMAT_NV12 for the same. - Shashank <o:p></o:p> </blockquote> What I mean to say here is, the check (1 << 24) is not good enough for all NV12, as you have to use it as if (mask == YCBCR_420_FORMAT_NV12) not (mask & YCBCR_420_FORMAT_NV12). But if that's how its intended to be used for future addition of P010/012/016, then I guess you can bypass this comment, but please make sure you differentiate NV12 with those formats. - Shashank <o:p></o:p> <o:p> </o:p> Sure thank u, will take care when P0xx gets added.<o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> default: case PLANE_CTL_FORMAT_XRGB_8888: if (rgb_order) { <o:p></o:p> </blockquote> </blockquote> </blockquote> <o:p> </o:p> </blockquote> <o:p> </o:p> </div> </div> </body> </html>