<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 28/03/18 19:29, Tvrtko Ursulin
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20180328182948.27494-1-tvrtko.ursulin@linux.intel.com">
<pre wrap="">From: Tvrtko Ursulin <a class="moz-txt-link-rfc2396E" href="mailto:tvrtko.ursulin@intel.com" moz-do-not-send="true"><tvrtko.ursulin@intel.com></a>
intel-gpu-top is a dangerous tool which can hang machines due unsafe mmio
register access. This patch rewrites it to use only PMU.
Only overall command streamer busyness and GPU global data such as power
and frequencies are included in this new version.
For access to more GPU functional unit level data, an OA metric based tool
like gpu-top should be used instead.
Signed-off-by: Tvrtko Ursulin <a class="moz-txt-link-rfc2396E" href="mailto:tvrtko.ursulin@intel.com" moz-do-not-send="true"><tvrtko.ursulin@intel.com></a>
Cc: Chris Wilson <a class="moz-txt-link-rfc2396E" href="mailto:chris@chris-wilson.co.uk" moz-do-not-send="true"><chris@chris-wilson.co.uk></a>
Cc: Lionel Landwerlin <a class="moz-txt-link-rfc2396E" href="mailto:lionel.g.landwerlin@intel.com" moz-do-not-send="true"><lionel.g.landwerlin@intel.com></a>
Cc: Petri Latvala <a class="moz-txt-link-rfc2396E" href="mailto:petri.latvala@intel.com" moz-do-not-send="true"><petri.latvala@intel.com></a>
</pre>
</blockquote>
<br>
Looks good to me too. Sorry, this isn't a detailed review, but since
it's a lot safer :<br>
<br>
Reviewed-by: Lionel Landwerlin <a class="moz-txt-link-rfc2396E" href="mailto:lionel.g.landwerlin@intel.com"><lionel.g.landwerlin@intel.com></a><br>
</body>
</html>