<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">>>
</span>I'm pretty sure Dmitry wants dynamic configurations.<br>
<br>
<span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Yes, I afraid we really need dynamic slice configurations for media.<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"> Landwerlin, Lionel G
<br>
<b>Sent:</b> Friday, May 4, 2018 9:25 AM<br>
<b>To:</b> Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; intel-gfx@lists.freedesktop.org; Rogozhkin, Dmitry V <dmitry.v.rogozhkin@intel.com><br>
<b>Subject:</b> Re: [Intel-gfx] [PATCH 8/8] drm/i915: Expose RPCS (SSEU) configuration to userspace<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 03/05/18 18:18, Tvrtko Ursulin wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"> +int intel_lr_context_set_sseu(struct i915_gem_context *ctx,
<br>
+ struct intel_engine_cs *engine, <br>
+ struct i915_gem_context_sseu *sseu) <br>
+{ <br>
+ struct drm_i915_private *dev_priv = ctx->i915; <br>
+ struct intel_context *ce; <br>
+ enum intel_engine_id id; <br>
+ int ret; <br>
+ <br>
+ lockdep_assert_held(&dev_priv->drm.struct_mutex); <br>
+ <br>
+ if (memcmp(sseu, &ctx->engine[engine->id].sseu, sizeof(*sseu)) == 0) <br>
+ return 0; <br>
+ <br>
+ /* <br>
+ * We can only program this on render ring. <br>
+ */ <br>
+ ce = &ctx->engine[RCS]; <br>
+ <br>
+ if (ce->pin_count) { /* Assume that the context is active! */ <br>
+ ret = i915_gem_switch_to_kernel_context(dev_priv); <br>
+ if (ret) <br>
+ return ret; <br>
+ <br>
+ ret = i915_gem_wait_for_idle(dev_priv, <br>
+ I915_WAIT_INTERRUPTIBLE | <br>
+ I915_WAIT_LOCKED); <o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><br>
Could we consider the alternative of only allowing this to be configured on context create? That way we would not need to idle the GPU every time userspace decides to fiddle with it. It is unprivileged so quite an easy way for random app to ruin GPU performance
for everyone. <br>
<br>
Regards, <br>
<br>
Tvrtko <o:p></o:p></p>
</blockquote>
<p><o:p> </o:p></p>
<p class="MsoNormal">I'm pretty sure Dmitry wants dynamic configurations.<br>
<br>
Dmitry?<o:p></o:p></p>
</div>
</body>
</html>