<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">Am 25.10.18 um 11:03 schrieb zhoucm1: </div> <blockquote type="cite" cite="mid:14a02772-5277-3ef2-91f8-1ef3858c1bbe@amd.com"> <div class="moz-cite-prefix">On 2018年10月25日 16:56, Christian König wrote: </div> <blockquote type="cite" cite="mid:6f63db7a-e51b-5829-9eb0-265ebd6dd99c@gmail.com"> <blockquote type="cite" style="color: #000000;">+++ b/drivers/gpu/drm/drm_syncobj.c @@ -111,15 +111,16 @@ static struct dma_fence uint64_t point) { struct drm_syncobj_signal_pt *signal_pt; + struct dma_fence *f = NULL; + struct drm_syncobj_stub_fence *fence = + kzalloc(sizeof(struct drm_syncobj_stub_fence), + GFP_KERNEL); + if (!fence) + return NULL; + spin_lock(&syncobj->pt_lock); </blockquote> How about using a single static stub fence like I suggested? </blockquote> Sorry, I don't get your meanings, how to do that? </blockquote> Add a new function drm_syncobj_stub_fence_init() which is called from drm_core_init() when the module is loaded. In drm_syncobj_stub_fence_init() you initialize one static stub_fence which is then used over and over again. Since its reference count never goes down to zero it should never be freed. In doubt maybe add a .free callback which just calls BUG() to catch reference count issues. Christian. <blockquote type="cite" cite="mid:14a02772-5277-3ef2-91f8-1ef3858c1bbe@amd.com"> Thanks, David </blockquote> </body> </html>