<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body dir="auto">
Hi Ville,
<div><br>
</div>
<div>The bits is 5-7 means it’s 001x xxxx for 2.97Gbps, and 010x xxxx for 1.65Gbps.</div>
<div>So correct value should be 2 not 1 for <span style="background-color: rgba(255, 255, 255, 0);">
HDMI_MAX_DATA_RATE_297.</span></div>
<div>And <span style="background-color: rgba(255, 255, 255, 0);">HDMI_MAX_DATA_RATE_165 is 4 not 2.</span></div>
<div><br>
</div>
<div>I checked kernel i915 log and modified VBT to limit HDMI 1.4 from HDMI 2.0 then found this error. And I run CrOS on GLK with changed VBT to validate it. Thanks,<br>
<br>
<div dir="ltr" id="AppleMailSignature">Best Regards,
<div>Cooper</div>
</div>
<div dir="ltr"><br>
On Apr 9, 2019, at 8:45 PM, Ville Syrjälä <<a href="mailto:ville.syrjala@linux.intel.com">ville.syrjala@linux.intel.com</a>> wrote:<br>
<br>
</div>
<blockquote type="cite">
<div dir="ltr"><span>On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote:</span><br>
<blockquote type="cite"><span>VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and 1.65Gbps
</span><br>
</blockquote>
<blockquote type="cite"><span>is 0x04, so changed </span><font color="#000000"><span style="caret-color: rgb(0, 0, 0); background-color: rgba(255, 255, 255, 0);">HDMI_MAX_DATA_RATE_297</span></font>/HDMI_MAX_DATA_RATE_165 to map </blockquote>
</div>
</blockquote>
<blockquote type="cite">
<div dir="ltr">
<blockquote type="cite"><span>correct values</span><br>
</blockquote>
<span></span><br>
<span>Eh what? Did someone just change the interpretation of these bits?</span><br>
<span></span><br>
<blockquote type="cite"><span>Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max. data</span><br>
</blockquote>
<blockquote type="cite"><span>rate 000=Default, 001=2.97Gbps, 010=1.65Gbps,</span><br>
</blockquote>
<span></span><br>
<span>Here you're quoting the values we already use...</span><br>
<span></span><br>
<blockquote type="cite"><span>so HDMI_MAX_DATA_RATE_297 </span><br>
</blockquote>
<blockquote type="cite"><span>should be 2 and HDMI_MAX_DATA_RATE_165 should be 4</span><br>
</blockquote>
<span></span><br>
<span>...but here you're using different values again? Which way is it?</span><br>
<span></span><br>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>TEST: Validated PASS on GLK RVP platform</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>Cc: Jani Nikula <<a href="mailto:jani.nikula@intel.com">jani.nikula@intel.com</a>></span><br>
</blockquote>
<blockquote type="cite"><span>Signed-off-by: Chiou, Cooper <<a href="mailto:cooper.chiou@intel.com">cooper.chiou@intel.com</a>></span><br>
</blockquote>
<blockquote type="cite"><span>---</span><br>
</blockquote>
<blockquote type="cite"><span>drivers/gpu/drm/i915/intel_vbt_defs.h | 4 ++--</span><br>
</blockquote>
<blockquote type="cite"><span>1 file changed, 2 insertions(+), 2 deletions(-)</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h</span><br>
</blockquote>
<blockquote type="cite"><span>index bf3662ad5fed..e2b8d042912b 100644</span><br>
</blockquote>
<blockquote type="cite"><span>--- a/drivers/gpu/drm/i915/intel_vbt_defs.h</span><br>
</blockquote>
<blockquote type="cite"><span>+++ b/drivers/gpu/drm/i915/intel_vbt_defs.h</span><br>
</blockquote>
<blockquote type="cite"><span>@@ -307,8 +307,8 @@ struct bdb_general_features {</span><br>
</blockquote>
<blockquote type="cite"><span>#define DVO_PORT_MIPID 24 /* 171 */</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>#define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */</span><br>
</blockquote>
<blockquote type="cite"><span>-#define HDMI_MAX_DATA_RATE_297 1 /* 204 */</span><br>
</blockquote>
<blockquote type="cite"><span>-#define HDMI_MAX_DATA_RATE_165 2 /* 204 */</span><br>
</blockquote>
<blockquote type="cite"><span>+#define HDMI_MAX_DATA_RATE_297 2 /* 212 */</span><br>
</blockquote>
<blockquote type="cite"><span>+#define HDMI_MAX_DATA_RATE_165 4 /* 212 */</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>#define LEGACY_CHILD_DEVICE_CONFIG_SIZE 33</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>-- </span><br>
</blockquote>
<blockquote type="cite"><span>2.7.4</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>_______________________________________________</span><br>
</blockquote>
<blockquote type="cite"><span>Intel-gfx mailing list</span><br>
</blockquote>
<blockquote type="cite"><span><a href="mailto:Intel-gfx@lists.freedesktop.org">Intel-gfx@lists.freedesktop.org</a></span><br>
</blockquote>
<blockquote type="cite"><span><a href="https://lists.freedesktop.org/mailman/listinfo/intel-gfx">https://lists.freedesktop.org/mailman/listinfo/intel-gfx</a></span><br>
</blockquote>
<span></span><br>
<span>-- </span><br>
<span>Ville Syrjälä</span><br>
<span>Intel</span><br>
</div>
</blockquote>
</div>
</body>
</html>