<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoPlainText"><a name="_MailEndCompose">Hi Ville,<o:p></o:p></a></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">From Intel BSpec, this is HDMI max data rate bits field definition as the following, and please find my experiment/log below. And as I knew, all platforms are using Default 000 for max data rate. (No any platform used 2.97/1.65 definition
in VBT so far). That’s why I correct HDMI max. data rate definition to be right value in 2.97 & 1.65Gbps. Thanks,<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">“HDMI max data rate and level shifter value” defined in BSpec:<o:p></o:p></p>
<p class="MsoPlainText">Bits 7 – 5 = HDMI Maximum Data Rate<o:p></o:p></p>
<p class="MsoPlainText"> 000 = Default (Software should choose the maximum data rate as supported by platform BSpec)<o:p></o:p></p>
<p class="MsoPlainText"> 001 = 2.97 GT/s<o:p></o:p></p>
<p class="MsoPlainText"> 010 = 1.65 GT/s<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Bit 4 - 0 = HDMI Level shifter value selection<o:p></o:p></p>
<p class="MsoPlainText"> Values differ from platform to platform<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">1. When I set HDMI <b>TMDS = 2.97Gbps</b> in GLK VBT, then i915 intel_bios.c parse_ddi_port() function got “<b>hdmi_max_data_rate=2</b>”.<o:p></o:p></p>
<p class="MsoPlainText"><img width="343" height="82" id="Picture_x0020_2" src="cid:image003.jpg@01D4EFC8.6DB4F360"><o:p></o:p></p>
<p class="MsoPlainText">DEBUG kernel: [ 0.172359] [drm:intel_bios_init] Port B VBT info: DP:0 HDMI:1 DVI:1 EDP:0 CRT:0<o:p></o:p></p>
<p class="MsoPlainText">DEBUG kernel: [ 0.172360] [drm:intel_bios_init] VBT HDMI level shift for port B: 8
<o:p></o:p></p>
<p class="MsoPlainText">DEBUG kernel: [ 0.172362] [drm:intel_bios_init] [Cooper] bdb_version=212
<o:p></o:p></p>
<p class="MsoPlainText">DEBUG kernel: [ 0.172363] [drm:intel_bios_init] [Cooper]
<b>hdmi_max_data_rate=2</b> <o:p></o:p></p>
<p class="MsoPlainText">DEBUG kernel: [ 0.172364] [drm:intel_bios_init] [Cooper] max_tmds_clock=165000
<o:p></o:p></p>
<p class="MsoPlainText">DEBUG kernel: [ 0.172365] [drm:intel_bios_init] VBT HDMI max TMDS clock for port B: 165000 kHz<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">2. When I set HDMI <b>TMDS = 1,65Gbps</b> in GLK VBT, then i915 intel_bios.c parse_ddi_port() function got “<b>hdmi_max_data_rate=4</b>”.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">DEBUG kernel: [ 0.172363] [drm:intel_bios_init] Port B VBT info: DP:0 HDMI:1 DVI:1 EDP:0 CRT:0
<o:p></o:p></p>
<p class="MsoPlainText">DEBUG kernel: [ 0.172364] [drm:intel_bios_init] VBT HDMI level shift for port B: 8 <o:p></o:p></p>
<p class="MsoPlainText">DEBUG kernel: [ 0.172365] [drm:intel_bios_init] [Cooper] bdb_version=212
<o:p></o:p></p>
<p class="MsoPlainText">DEBUG kernel: [ 0.172366] [drm:intel_bios_init] [Cooper]
<b>hdmi_max_data_rate=4</b> <o:p></o:p></p>
<p class="MsoPlainText">WARNING kernel: [ 0.172367] ------------[ cut here ]------------
<o:p></o:p></p>
<p class="MsoPlainText">WARNING kernel: [ 0.172369] <b>Missing switch case (4) in parse_ddi_port
</b><o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Best Regards,<o:p></o:p></p>
<p class="MsoPlainText">Cooper<o:p></o:p></p>
<p class="MsoPlainText">+886-2-6622-1166<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><a name="_____replyseparator"></a>-----Original Message-----<br>
From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com] <br>
Sent: Tuesday, April 9, 2019 23:57 PM<br>
To: Chiou, Cooper <cooper.chiou@intel.com><br>
Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani <jani.nikula@intel.com>; Chiou@freedesktop.org<br>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT</p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">On Tue, Apr 09, 2019 at 03:46:20PM +0000, Chiou, Cooper wrote:<o:p></o:p></p>
<p class="MsoPlainText">> Hi Ville,<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> The bits is 5-7 means it’s 001x xxxx for 2.97Gbps, and 010x xxxx for 1.65Gbps.<o:p></o:p></p>
<p class="MsoPlainText">> So correct value should be 2 not 1 for HDMI_MAX_DATA_RATE_297.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">No. The bitfield is defined as something:3.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">> And HDMI_MAX_DATA_RATE_165 is 4 not 2.<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> I checked kernel i915 log and modified VBT to limit HDMI 1.4 from HDMI
<o:p></o:p></p>
<p class="MsoPlainText">> 2.0 then found this error. And I run CrOS on GLK with changed VBT to
<o:p></o:p></p>
<p class="MsoPlainText">> validate it. Thanks,<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> Best Regards,<o:p></o:p></p>
<p class="MsoPlainText">> Cooper<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> On Apr 9, 2019, at 8:45 PM, Ville Syrjälä <<a href="mailto:ville.syrjala@linux.intel.com%3cmailto:ville.syrjala@linux.intel.com"><span style="color:windowtext;text-decoration:none">ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com</span></a>>>
wrote:<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote:<o:p></o:p></p>
<p class="MsoPlainText">> VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and
<o:p></o:p></p>
<p class="MsoPlainText">> 1.65Gbps is 0x04, so changed <o:p></o:p></p>
<p class="MsoPlainText">> HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map correct values<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> Eh what? Did someone just change the interpretation of these bits?<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max.
<o:p></o:p></p>
<p class="MsoPlainText">> data rate 000=Default, 001=2.97Gbps, 010=1.65Gbps,<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> Here you're quoting the values we already use...<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> so HDMI_MAX_DATA_RATE_297<o:p></o:p></p>
<p class="MsoPlainText">> should be 2 and HDMI_MAX_DATA_RATE_165 should be 4<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> ...but here you're using different values again? Which way is it?<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> TEST: Validated PASS on GLK RVP platform<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> Cc: Jani Nikula <<a href="mailto:jani.nikula@intel.com%3cmailto:jani.nikula@intel.com"><span style="color:windowtext;text-decoration:none">jani.nikula@intel.com<mailto:jani.nikula@intel.com</span></a>>><o:p></o:p></p>
<p class="MsoPlainText">> Signed-off-by: Chiou, Cooper <o:p></o:p></p>
<p class="MsoPlainText">> <<a href="mailto:cooper.chiou@intel.com%3cmailto:cooper.chiou@intel.com"><span style="color:windowtext;text-decoration:none">cooper.chiou@intel.com<mailto:cooper.chiou@intel.com</span></a>>><o:p></o:p></p>
<p class="MsoPlainText">> ---<o:p></o:p></p>
<p class="MsoPlainText">> drivers/gpu/drm/i915/intel_vbt_defs.h | 4 ++--<o:p></o:p></p>
<p class="MsoPlainText">> 1 file changed, 2 insertions(+), 2 deletions(-)<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h <o:p>
</o:p></p>
<p class="MsoPlainText">> b/drivers/gpu/drm/i915/intel_vbt_defs.h<o:p></o:p></p>
<p class="MsoPlainText">> index bf3662ad5fed..e2b8d042912b 100644<o:p></o:p></p>
<p class="MsoPlainText">> --- a/drivers/gpu/drm/i915/intel_vbt_defs.h<o:p></o:p></p>
<p class="MsoPlainText">> +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h<o:p></o:p></p>
<p class="MsoPlainText">> @@ -307,8 +307,8 @@ struct bdb_general_features {<o:p></o:p></p>
<p class="MsoPlainText">> #define DVO_PORT_MIPID 24 /* 171 */<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> #define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */<o:p></o:p></p>
<p class="MsoPlainText">> -#define HDMI_MAX_DATA_RATE_297 1 /* 204 */<o:p></o:p></p>
<p class="MsoPlainText">> -#define HDMI_MAX_DATA_RATE_165 2 /* 204 */<o:p></o:p></p>
<p class="MsoPlainText">> +#define HDMI_MAX_DATA_RATE_297 2 /* 212 */<o:p></o:p></p>
<p class="MsoPlainText">> +#define HDMI_MAX_DATA_RATE_165 4 /* 212 */<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> #define LEGACY_CHILD_DEVICE_CONFIG_SIZE 33<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> --<o:p></o:p></p>
<p class="MsoPlainText">> 2.7.4<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> _______________________________________________<o:p></o:p></p>
<p class="MsoPlainText">> Intel-gfx mailing list<o:p></o:p></p>
<p class="MsoPlainText">> <a href="mailto:Intel-gfx@lists.freedesktop.org%3cmailto:Intel-gfx@lists.freedesktop.org">
<span style="color:windowtext;text-decoration:none">Intel-gfx@lists.freedesktop.org<mailto:Intel-gfx@lists.freedesktop.org</span></a><o:p></o:p></p>
<p class="MsoPlainText">> > <a href="https://lists.freedesktop.org/mailman/listinfo/intel-gfx">
<span style="color:windowtext;text-decoration:none">https://lists.freedesktop.org/mailman/listinfo/intel-gfx</span></a><o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> --<o:p></o:p></p>
<p class="MsoPlainText">> Ville Syrjälä<o:p></o:p></p>
<p class="MsoPlainText">> Intel<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">--<o:p></o:p></p>
<p class="MsoPlainText">Ville Syrjälä<o:p></o:p></p>
<p class="MsoPlainText">Intel<o:p></o:p></p>
</div>
</body>
</html>