<div dir="ltr"><div>While I'm generally a fan of this change, we've been talking on IRC a bit today and, apparently, the X server hasn't actually had a release where modifiers have been enabled by default so this is causing problems. Adam & Daniel, is there something that's preventing us from enabling it by default? This is kind-of important these days.</div><div><br></div><div>--Jason</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 20, 2019 at 12:06 PM Daniel Vetter <<a href="mailto:daniel.vetter@ffwll.ch">daniel.vetter@ffwll.ch</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The cpu (de)tiler hw is gone, this stopped being useful. Plus it never<br>
supported any of the fancy new tiling formats, which means userspace<br>
also stopped using the magic side-channel this provides.<br>
<br>
This would totally break a lot of the igts, but they're already broken<br>
for the same reasons as userspace on gen12 would be.<br>
<br>
Cc: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>><br>
Cc: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>><br>
Cc: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk" target="_blank">chris@chris-wilson.co.uk</a>><br>
Cc: Lucas De Marchi <<a href="mailto:lucas.demarchi@intel.com" target="_blank">lucas.demarchi@intel.com</a>><br>
Signed-off-by: Daniel Vetter <<a href="mailto:daniel.vetter@intel.com" target="_blank">daniel.vetter@intel.com</a>><br>
---<br>
drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 8 ++++++++<br>
1 file changed, 8 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c<br>
index ca0c2f451742..2ee96f27a294 100644<br>
--- a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c<br>
+++ b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c<br>
@@ -313,10 +313,15 @@ int<br>
i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data,<br>
struct drm_file *file)<br>
{<br>
+ struct drm_i915_private *dev_priv = to_i915(dev);<br>
struct drm_i915_gem_set_tiling *args = data;<br>
struct drm_i915_gem_object *obj;<br>
int err;<br>
<br>
+ /* there is no cpu (de)tiling in the hw anymore on gen12+ */<br>
+ if (INTEL_GEN(dev_priv) >= 12)<br>
+ return -EOPNOTSUPP;<br>
+<br>
obj = i915_gem_object_lookup(file, args->handle);<br>
if (!obj)<br>
return -ENOENT;<br>
@@ -402,6 +407,9 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data,<br>
struct drm_i915_gem_object *obj;<br>
int err = -ENOENT;<br>
<br>
+ if (INTEL_GEN(dev_priv) >= 12)<br>
+ return -EOPNOTSUPP;<br>
+<br>
rcu_read_lock();<br>
obj = i915_gem_object_lookup_rcu(file, args->handle);<br>
if (obj) {<br>
-- <br>
2.23.0.rc1<br>
<br>
</blockquote></div>