<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <meta content="text/html; charset=UTF-8"> <style type="text/css" style="">  </style> <div dir="ltr"> <div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif"> <pre class="x_content" style="overflow:auto; font-family:Menlo,Monaco,Consolas,"Courier New",monospace; font-size:13px; padding:9.5px; margin-top:0px; margin-bottom:10px; line-height:14.3px; word-break:break-all; border:0px; border-radius:0px">>> Add correspondent helpers to be able to get old/new bandwidth >> global state object. >> >> v2: - Fixed typo in function call >> v3: - Changed new functions naming to use convention proposed >> by Jani Nikula, i.e intel_bw_* in intel_bw.c file. >Still nak on the rename.</pre> <pre class="x_content" style="overflow:auto; font-family:Menlo,Monaco,Consolas,"Courier New",monospace; font-size:13px; padding:9.5px; margin-top:0px; margin-bottom:10px; line-height:14.3px; word-break:break-all; border:0px; border-radius:0px">Cool. Discuss it with Jani Nikula then, to have at least some common strategy on how to be picky on me.</pre> <pre class="x_content" style="overflow:auto; font-family:Menlo,Monaco,Consolas,"Courier New",monospace; font-size:13px; padding:9.5px; margin-top:0px; margin-bottom:10px; line-height:14.3px; word-break:break-all; border:0px; border-radius:0px"></pre> <div id="x_Signature"> <div style="font-family:Tahoma; font-size:13px">Best Regards, Lisovskiy Stanislav </div> </div> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr">From: Ville Syrjälä <ville.syrjala@linux.intel.com> Sent: Wednesday, March 11, 2020 6:08:54 PM To: Lisovskiy, Stanislav Cc: intel-gfx@lists.freedesktop.org; Ausmus, James; Saarinen, Jani; Roper, Matthew D Subject: Re: [PATCH v19 3/8] drm/i915: Add intel_bw_get_*_state helpers <div> </div> </div> </div> <div class="PlainText">On Mon, Mar 09, 2020 at 06:11:59PM +0200, Stanislav Lisovskiy wrote: > Add correspondent helpers to be able to get old/new bandwidth > global state object. > > v2: - Fixed typo in function call > v3: - Changed new functions naming to use convention proposed > by Jani Nikula, i.e intel_bw_* in intel_bw.c file. Still nak on the rename. > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > --- > drivers/gpu/drm/i915/display/intel_bw.c | 33 ++++++++++++++++++++++--- > drivers/gpu/drm/i915/display/intel_bw.h | 9 +++++++ > 2 files changed, 39 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c > index 58b264bc318d..bdad7476dc7b 100644 > --- a/drivers/gpu/drm/i915/display/intel_bw.c > +++ b/drivers/gpu/drm/i915/display/intel_bw.c > @@ -374,8 +374,35 @@ static unsigned int intel_bw_data_rate(struct drm_i915_private *dev_priv, > return data_rate; > } > > -static struct intel_bw_state * > -intel_atomic_get_bw_state(struct intel_atomic_state *state) > +struct intel_bw_state * > +intel_bw_get_old_state(struct intel_atomic_state *state) > +{ > + struct drm_i915_private *dev_priv = to_i915(state->base.dev); > + struct intel_global_state *bw_state; > + > + bw_state = intel_atomic_get_old_global_obj_state(state, &dev_priv->bw_obj); > + if (IS_ERR(bw_state)) > + return ERR_CAST(bw_state); > + > + return to_intel_bw_state(bw_state); > +} > + > +struct intel_bw_state * > +intel_bw_get_new_state(struct intel_atomic_state *state) > +{ > + struct drm_i915_private *dev_priv = to_i915(state->base.dev); > + struct intel_global_state *bw_state; > + > + bw_state = intel_atomic_get_new_global_obj_state(state, &dev_priv->bw_obj); > + > + if (IS_ERR(bw_state)) > + return ERR_CAST(bw_state); > + > + return to_intel_bw_state(bw_state); > +} > + > +struct intel_bw_state * > +intel_bw_get_state(struct intel_atomic_state *state) > { > struct drm_i915_private *dev_priv = to_i915(state->base.dev); > struct intel_global_state *bw_state; > @@ -420,7 +447,7 @@ int intel_bw_atomic_check(struct intel_atomic_state *state) > old_active_planes == new_active_planes) > continue; > > - bw_state = intel_atomic_get_bw_state(state); > + bw_state = intel_bw_get_state(state); > if (IS_ERR(bw_state)) > return PTR_ERR(bw_state); > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.h b/drivers/gpu/drm/i915/display/intel_bw.h > index a8aa7624c5aa..b5f61463922f 100644 > --- a/drivers/gpu/drm/i915/display/intel_bw.h > +++ b/drivers/gpu/drm/i915/display/intel_bw.h > @@ -24,6 +24,15 @@ struct intel_bw_state { > > #define to_intel_bw_state(x) container_of((x), struct intel_bw_state, base) > > +struct intel_bw_state * > +intel_bw_get_old_state(struct intel_atomic_state *state); > + > +struct intel_bw_state * > +intel_bw_get_new_state(struct intel_atomic_state *state); > + > +struct intel_bw_state * > +intel_bw_get_state(struct intel_atomic_state *state); > + > void intel_bw_init_hw(struct drm_i915_private *dev_priv); > int intel_bw_init(struct drm_i915_private *dev_priv); > int intel_bw_atomic_check(struct intel_atomic_state *state); > -- > 2.24.1.485.gad05a3d8e5 -- Ville Syrjälä Intel </div> </body> </html>