<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">On 14/04/2020 02:34, Umesh Nerlige
Ramappa wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20200413233409.GC61072@orsosgc001.amr.corp.intel.com">
<blockquote type="cite" style="color: #000000;">- * When
set globally, we use a low priority kernel context,
<br>
- * so it will effectively take effect when idle.
<br>
- */
<br>
- ret = emit_oa_config(stream, config, ce,
<br>
+ ret = emit_oa_config(stream, config,
<br>
+ stream->config_context,
<br>
active, false /* global */);
<br>
if (ret)
<br>
goto err_active;
<br>
<br>
- ret = emit_oa_config(stream, config, ce,
<br>
+ ret = emit_oa_config(stream, config,
<br>
+ stream->config_context,
<br>
active, true /* global */);
<br>
</blockquote>
<br>
I see emit_oa_config is called twice in all places (except the for
loop below). Maybe all those places, these 2 calls can be wrapped
into one function.
<br>
<br>
Thanks,
<br>
Umesh
</blockquote>
<p>Good point, I'll add a helper.</p>
<p><br>
</p>
<p>Thanks,</p>
<p><br>
</p>
<p>-Lionel<br>
</p>
</body>
</html>