<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> </head> <body> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255);" dir="auto"> Hi Jani</div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255);" dir="auto"> <br> </div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255);" dir="auto"> Please review the patch and tell is something else is required.</div> <div id="ms-outlook-mobile-signature" dir="auto"> <div dir="auto"><br> </div> </div> <div id="id-d638465e-17ed-4fbd-9acc-c8f41931950e" class="ms-outlook-mobile-reference-message" dir="auto"> <div style="font-family: sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg"><strong>From:</strong> Ashish Arora <ashisharora.linux@outlook.com><br> <strong>Sent:</strong> Friday, 7 January, 2022, 8:32 pm<br> <strong>To:</strong> jani.nikula@linux.intel.com; joonas.lahtinen@linux.intel.com; rodrigo.vivi@intel.com<br> <strong>Cc:</strong> intel-gfx@lists.freedesktop.org; Linux Kernel Mailing List<br> <strong>Subject:</strong> [PATCH - v2] drm/i915: Discard large BIOS framebuffers causing display corruption.<br> </div> <br> <meta name="Generator" content="Microsoft Exchange Server"> <style></style><font size="2"><span style="font-size:11pt;"> <div class="PlainText">From: Ashish Arora <ashisharora.linux@outlook.com><br> <br> On certain 4k panels, the BIOS framebuffer is larger than what panel<br> requires causing display corruption. Introduce a check for the same.<br> <br> Signed-off-by: Ashish Arora <ashisharora.linux@outlook.com><br> ---<br> drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---<br> 1 file changed, 3 insertions(+), 3 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c<br> index adc3a81be..0a64184df 100644<br> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c<br> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c<br> @@ -194,10 +194,10 @@ static int intelfb_create(struct drm_fb_helper *helper,<br> int ret;<br> <br> if (intel_fb &&<br> - (sizes->fb_width > intel_fb->base.width ||<br> - sizes->fb_height > intel_fb->base.height)) {<br> + (sizes->fb_width != intel_fb->base.width ||<br> + sizes->fb_height != intel_fb->base.height)) {<br> drm_dbg_kms(&dev_priv->drm,<br> - "BIOS fb too small (%dx%d), we require (%dx%d),"<br> + "BIOS fb not valid (%dx%d), we require (%dx%d),"<br> " releasing it\n",<br> intel_fb->base.width, intel_fb->base.height,<br> sizes->fb_width, sizes->fb_height);<br> -- <br> 2.25.1<br> <br> <br> </div> </span></font><br> </div> </body> </html>