<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 22, 2022 at 2:45 PM José Roberto de Souza <<a href="mailto:jose.souza@intel.com">jose.souza@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">skl_compute_ddb() will for a modeset in all pipes when MBUS joining<br>
changes between states, so all pipes will be disabled, have all<br>
MBUS related registers updated and then each pipe enabled.<br></blockquote><div>I am not clear what you want to say here. Could you rephrase above 3 lines?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
So no vblank syncronization is necessary and here droping those TODOs.<br></blockquote><div> dropping</div><div>-caz</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Cc: Ville Syrjälä <<a href="mailto:ville.syrjala@linux.intel.com" target="_blank">ville.syrjala@linux.intel.com</a>><br>
Signed-off-by: José Roberto de Souza <<a href="mailto:jose.souza@intel.com" target="_blank">jose.souza@intel.com</a>><br>
---<br>
drivers/gpu/drm/i915/intel_pm.c | 5 -----<br>
1 file changed, 5 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c<br>
index cf290bb704221..9ccf0f062862c 100644<br>
--- a/drivers/gpu/drm/i915/intel_pm.c<br>
+++ b/drivers/gpu/drm/i915/intel_pm.c<br>
@@ -6066,7 +6066,6 @@ skl_compute_ddb(struct intel_atomic_state *state)<br>
return ret;<br>
<br>
if (old_dbuf_state->joined_mbus != new_dbuf_state->joined_mbus) {<br>
- /* TODO: Implement vblank synchronized MBUS joining changes */<br>
ret = intel_modeset_all_pipes(state);<br>
if (ret)<br>
return ret;<br>
@@ -8195,10 +8194,6 @@ static void update_mbus_pre_enable(struct intel_atomic_state *state)<br>
if (!HAS_MBUS_JOINING(dev_priv))<br>
return;<br>
<br>
- /*<br>
- * TODO: Implement vblank synchronized MBUS joining changes.<br>
- * Must be properly coordinated with dbuf reprogramming.<br>
- */<br>
if (dbuf_state->joined_mbus) {<br>
mbus_ctl = MBUS_HASHING_MODE_1x4 | MBUS_JOIN |<br>
MBUS_JOIN_PIPE_SELECT_NONE;<br>
-- <br>
2.35.1<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>-caz, caz at caztech dot com, 503-six one zero - five six nine nine(m)<br></div></div></div></div></div></div></div></div></div></div></div></div>