<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div>On Thu, 2022-08-18 at 17:27 +0300, Jani Nikula wrote:</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>On Thu, 18 Aug 2022, Jani Nikula <<a href="mailto:jani.nikula@intel.com">jani.nikula@intel.com</a>> wrote:<br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>On Wed, 17 Aug 2022, "Colin King (gmail)" <<a href="mailto:colin.i.king@gmail.com">colin.i.king@gmail.com</a>> wrote:<br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>On 17/08/2022 21:07, Vivi, Rodrigo wrote:<br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>On Tue, 2022-08-16 at 12:43 +0800, Zhenyu Wang wrote:<br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>On 2022.08.16 12:05:08 +0800, Zhenyu Wang wrote:<br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>On 2022.08.15 19:32:45 -0400, Rodrigo Vivi wrote:<br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>On Mon, Aug 15, 2022 at 10:38:55AM +0800, Zhenyu Wang wrote:<br>
</div>
</blockquote>
</blockquote>
<div>oh, surprise! I just found Colin's email is actually defined in<br>
</div>
<div>.mailmap,<br>
</div>
<div>so all his commits in kernel are changed for @intel.com address as in<br>
</div>
<div>mailmap...<br>
</div>
</blockquote>
<div><br>
</div>
<div>Colin, would you mind to get the Sign-off-by in the patches the same<br>
</div>
<div>as your authorship so the tools don't get confused?<br>
</div>
<div>(starting with modifying in tree this already merged patch)<br>
</div>
</blockquote>
<div><br>
</div>
<div>Since my patches are generally trivial janitorial fixed done in my spare <br>
</div>
<div>time I'm going to get the .mailmap changed to use my gmail email address <br>
</div>
<div>rather than my Intel one (since I don't do kernel work in my current role).<br>
</div>
<div><br>
</div>
<div>This should clean up the confusion. Apologies.<br>
</div>
</blockquote>
<div><br>
</div>
<div>Everyone hold your horses.<br>
</div>
<div><br>
</div>
<div>I think our tooling should handle the mailmap stuff. The commit *is*<br>
</div>
<div>fine, it's just that the when we check it, we let mailmap alter it. We<br>
</div>
<div>should check the commit without mailmap modifications.<br>
</div>
</blockquote>
<div><br>
</div>
<div>In this case, it's actually not about Colin's Signed-off-by or mailmap<br>
</div>
<div>at all! Like the error message from dim says, "committer Signed-off-by<br>
</div>
<div>missing". Committer, not author!<br>
</div>
<div><br>
</div>
<div>$ git show -s tags/gvt-fixes-2022-08-15^ --pretty=fuller<br>
</div>
<div>commit d6632370536d0b80be3bfc90dd67e1f693335a75<br>
</div>
<div>Author: Colin Ian King <<a href="mailto:colin.king@intel.com">colin.king@intel.com</a>><br>
</div>
<div>AuthorDate: Tue Mar 15 20:24:49 2022 +0000<br>
</div>
<div>Commit: Zhenyu Wang <<a href="mailto:zhenyuw@linux.intel.com">zhenyuw@linux.intel.com</a>><br>
</div>
<div>CommitDate: Mon Aug 15 10:51:15 2022 +0800<br>
</div>
<div><br>
</div>
<div> drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"<br>
</div>
<div> <br>
</div>
<div> There is a spelling mistake in a gvt_vgpu_err error message. Fix it.<br>
</div>
<div> <br>
</div>
<div> Fixes: 695fbc08d80f ("drm/i915/gvt: replace the gvt_err with gvt_vgpu_err")<br>
</div>
<div> Signed-off-by: Colin Ian King <<a href="mailto:colin.i.king@gmail.com">colin.i.king@gmail.com</a>><br>
</div>
<div> Signed-off-by: Zhi Wang <<a href="mailto:zhi.a.wang@intel.com">zhi.a.wang@intel.com</a>><br>
</div>
<div> Link: <a href="http://patchwork.freedesktop.org/patch/msgid/20220315202449.2952845-1-colin.i.king@gmail.com">
http://patchwork.freedesktop.org/patch/msgid/20220315202449.2952845-1-colin.i.king@gmail.com</a><br>
</div>
<div> Reviewed-by: Zhi Wang <<a href="mailto:zhi.a.wang@intel.com">zhi.a.wang@intel.com</a>><br>
</div>
<div><br>
</div>
<div>Committed by Zhenyu, Signed-off-by Zhi. Maybe caused by rebase by Zhenyu<br>
</div>
<div>after being committed by Zhi?<br>
</div>
</blockquote>
<div><br>
</div>
<div>Probably easier if you could rebase it again signing it then?</div>
<div><br>
</div>
<div>I could bypass dim here, but this will likely affect someone else later in the upstream chain as well..</div>
<div><br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div><br>
</div>
<div>BR,<br>
</div>
<div>Jani.<br>
</div>
<div><br>
</div>
<div><br>
</div>
</blockquote>
<div><br>
</div>
<div><span></span></div>
</body>
</html>