<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> Hi Andi, <div class="moz-cite-prefix">On 4/5/2023 1:53 PM, Andi Shyti wrote: </div> <blockquote type="cite" cite="mid:ZC1hSRRKyU92kQ86@ashyti-mobl2.lan"> <pre class="moz-quote-pre" wrap="">Hi Nirmoy, </pre> <blockquote type="cite"> <blockquote type="cite"> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">Add a mechanism to keep existing data when creating a ttm object with I915_BO_ALLOC_USER flag. </pre> </blockquote> <pre class="moz-quote-pre" wrap="">why do we need this mechanism? What was the logic behind? These are all questions people might have when checking this commit. Please be a bit more explicative. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> Agree, the commit message is bit short. I will add more content in next revision. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> you don't need to send a new version just for this commit log. You could just propose a new commit log in the reply and if it's OK, add it before pushing it.</pre> </blockquote> <pre class="moz-quote-pre" wrap="">Let me know what do you think about: </pre> <pre>Add a mechanism to preserve existing data when creating a TTM</pre> <pre>object with the I915_BO_ALLOC_USER flag. This will be used in the subsequent</pre> <pre>patch where the I915_BO_ALLOC_USER flag will be applied to the framebuffer</pre> <pre>object. For a pre-allocated framebuffer without the I915_BO_PREALLOC flag,</pre> <pre>TTM would clear the content, which is not desirable.</pre> <pre> </pre> <pre>Thanks,</pre> <pre>Nirmoy </pre> <blockquote type="cite" cite="mid:ZC1hSRRKyU92kQ86@ashyti-mobl2.lan"> <pre class="moz-quote-pre" wrap=""> As you wish. Andi </pre> <blockquote type="cite"> <blockquote type="cite"> <pre class="moz-quote-pre" wrap=""> </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">Cc: Matthew Auld <a class="moz-txt-link-rfc2396E" href="mailto:matthew.auld@intel.com"><matthew.auld@intel.com></a> Cc: Andi Shyti <a class="moz-txt-link-rfc2396E" href="mailto:andi.shyti@linux.intel.com"><andi.shyti@linux.intel.com></a> Cc: Andrzej Hajda <a class="moz-txt-link-rfc2396E" href="mailto:andrzej.hajda@intel.com"><andrzej.hajda@intel.com></a> Cc: Ville Syrjälä <a class="moz-txt-link-rfc2396E" href="mailto:ville.syrjala@linux.intel.com"><ville.syrjala@linux.intel.com></a> Cc: Jani Nikula <a class="moz-txt-link-rfc2396E" href="mailto:jani.nikula@intel.com"><jani.nikula@intel.com></a> Cc: Imre Deak <a class="moz-txt-link-rfc2396E" href="mailto:imre.deak@intel.com"><imre.deak@intel.com></a> Signed-off-by: Nirmoy Das <a class="moz-txt-link-rfc2396E" href="mailto:nirmoy.das@intel.com"><nirmoy.das@intel.com></a> </pre> </blockquote> <pre class="moz-quote-pre" wrap="">Reviewed-by: Andi Shyti <a class="moz-txt-link-rfc2396E" href="mailto:andi.shyti@linux.intel.com"><andi.shyti@linux.intel.com></a> </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> Thanks, Nirmoy </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap=""> Thanks, Andi </pre> </blockquote> </blockquote> </blockquote> </body> </html>