<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof ContentPasted0 ContentPasted1"> > On 20/04/2023 12:39, Andi Shyti wrote: <div class="ContentPasted0">>> Hi Fei,</div> <div class="ContentPasted0">>></div> <div class="ContentPasted0">>>> To comply with the design that buffer objects shall have immutable</div> <div class="ContentPasted0">>>> cache setting through out their life cycle, {set, get}_caching ioctl's</div> <div class="ContentPasted0">>>> are no longer supported from MTL onward. With that change caching</div> <div class="ContentPasted0">>>> policy can only be set at object creation time. The current code</div> <div class="ContentPasted0">>>> applies a default (platform dependent) cache setting for all objects.</div> <div class="ContentPasted0">>>> However this is not optimal for performance tuning. The patch extends</div> <div class="ContentPasted0">>>> the existing gem_create uAPI to let user set PAT index for the object</div> <div class="ContentPasted0">>>> at creation time.</div> <div class="ContentPasted0">>>> The new extension is platform independent, so UMD's can switch to using</div> <div class="ContentPasted0">>>> this extension for older platforms as well, while {set, get}_caching are</div> <div class="ContentPasted0">>>> still supported on these legacy paltforms for compatibility reason.</div> <div class="ContentPasted0">>>></div> <div class="ContentPasted0">>>> Cc: Chris Wilson <chris.p.wilson@linux.intel.com></div> <div class="ContentPasted0">>>> Cc: Matt Roper <matthew.d.roper@intel.com></div> <div class="ContentPasted0">>>> Cc: Andi Shyti <andi.shyti@linux.intel.com></div> <div class="ContentPasted0">>>> Signed-off-by: Fei Yang <fei.yang@intel.com></div> <div class="ContentPasted0">>>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com></div> <div class="ContentPasted0">>></div> <div class="ContentPasted0">>> because this is an API change, we need some more information</div> <div class="ContentPasted0">>> here.</div> <div class="ContentPasted0">>></div> <div class="ContentPasted0">>> First of all you need to CC the userspace guys that have been</div> <div class="ContentPasted0">>> working on top of your series and get their ack's.</div> <div class="ContentPasted0">></div> <div class="ContentPasted0">> Yes, and a link to a Mesa merge request which uses the uapi should be</div> <div class="ContentPasted0">> included.</div> <div><br class="ContentPasted0"> </div> <div class="ContentPasted0">Working with Mesa team on this, stay tuned.</div> <div><br class="ContentPasted0"> </div> <div class="ContentPasted0">> IGTs should be ready to before we can merge. I glanced over igt-dev but</div> <div class="ContentPasted0">> did not spot anything.</div> <div><br class="ContentPasted0"> </div> <div class="ContentPasted0">There is a IGT patch posted to gfx-internal-devel, titled "test/gem_create: exercise gem_create_ext_set_pat"</div> <div><br class="ContentPasted0"> </div> <div class="ContentPasted0">> Regards,</div> <div class="ContentPasted0">></div> <div class="ContentPasted0">> Tvrtko</div> <div class="ContentPasted0">></div> >> <div class="ContentPasted1">>> I also believe that this series has also been tested on a</div> <div class="ContentPasted1">>> separate repository, would you link it in the commit message?</div> <div class="ContentPasted1">>></div> <div class="ContentPasted1">>> Thanks,</div> <div class="ContentPasted1">>> Andi</div> <br> </div> </body> </html>