<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof ContentPasted0 ContentPasted1">
> Hi Fei,
<div class="ContentPasted0">></div>
<div class="ContentPasted0">> On Fri, May 12, 2023 at 04:28:25PM -0700, fei.yang@intel.com wrote:</div>
<div class="ContentPasted0">>> From: Fei Yang <fei.yang@intel.com></div>
<div class="ContentPasted0">>></div>
<div class="ContentPasted0">>> To comply with the design that buffer objects shall have immutable</div>
<div class="ContentPasted0">>> cache setting through out their life cycle, {set, get}_caching ioctl's</div>
<div class="ContentPasted0">>> are no longer supported from MTL onward. With that change caching</div>
<div class="ContentPasted0">>> policy can only be set at object creation time. The current code</div>
<div class="ContentPasted0">>> applies a default (platform dependent) cache setting for all objects.</div>
<div class="ContentPasted0">>> However this is not optimal for performance tuning. The patch extends</div>
<div class="ContentPasted0">>> the existing gem_create uAPI to let user set PAT index for the object</div>
<div class="ContentPasted0">>> at creation time.</div>
<div class="ContentPasted0">>> The new extension is platform independent, so UMD's can switch to using</div>
<div class="ContentPasted0">>> this extension for older platforms as well, while {set, get}_caching are</div>
<div class="ContentPasted0">>> still supported on these legacy paltforms for compatibility reason.</div>
<div class="ContentPasted0">>></div>
<div class="ContentPasted0">>> IGT posted at https://patchwork.freedesktop.org/series/117695/</div>
<div class="ContentPasted0">></div>
<div class="ContentPasted0">> Test gem_create@create-ext-set-pat</div>
<div class="ContentPasted0">></div>
<div class="ContentPasted0">>> Tested with https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22878</div>
<div class="ContentPasted0">>></div>
<div class="ContentPasted0">>> Tested-by: Jordan Justen <jordan.l.justen@intel.com></div>
<div class="ContentPasted0">></div>
<div class="ContentPasted0">> we need here an explicit ack to have the paper work in place. So</div>
<div class="ContentPasted0">> that I still have to ask Jordan and Mesa folks to give an ack if</div>
<div class="ContentPasted0">> things look right.</div>
<div><br class="ContentPasted0">
</div>
<div class="ContentPasted0">Will update once an a-b is in place.</div>
<div><br class="ContentPasted0">
</div>
<div class="ContentPasted0">> Thanks!</div>
<div class="ContentPasted0">> Andi</div>
<div class="ContentPasted0">></div>
<div class="ContentPasted0">>> Cc: Chris Wilson <chris.p.wilson@linux.intel.com></div>
<div class="ContentPasted0">>> Cc: Matt Roper <matthew.d.roper@intel.com></div>
<div class="ContentPasted0">>> Cc: Andi Shyti <andi.shyti@linux.intel.com></div>
<div class="ContentPasted0">>> Signed-off-by: Fei Yang <fei.yang@intel.com></div>
<div class="ContentPasted0">>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com></div>
<div class="ContentPasted0">></div>
<div class="ContentPasted0">>PS:</div>
>
<div class="ContentPasted1">> nitnitnitpick: the tags need to come in chronological order. So</div>
<div class="ContentPasted1">> that:</div>
<div class="ContentPasted1">></div>
<div class="ContentPasted1">> - first you wrote it (Sob: Fei...)</div>
<div class="ContentPasted1">> - then you sent it (Cc: ...)</div>
<div class="ContentPasted1">> - then it has been reviewd (R-b)</div>
<div class="ContentPasted1">> - finally tested (T-b)</div>
<div class="ContentPasted1">></div>
<div class="ContentPasted1">> I see that many people put the "Cc:" before the "Sob:" and I</div>
<div class="ContentPasted1">> consider it a matter of taste (which might mean "I first prepare</div>
<div class="ContentPasted1">> the mail (Cc:) and then I send it (Sob:)").</div>
<div class="ContentPasted1">></div>
<div class="ContentPasted1">> But... don't mind too much at these things.</div>
<div class="ContentPasted1">></div>
<div class="ContentPasted1">>Andi</div>
<br>
</div>
</body>
</html>