<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<div dir="auto">Hi Ville,</div>
<div dir="auto"><br>
</div>
<div dir="auto">It was confirmed by Jani Nikula that it is 20. Here is his comments.</div>
<div dir="auto"><br>
</div>
<div dir="auto">".... <span style="font-size: 12pt;">display ver 20 is what the hardware reports to us. the current info is at bspecb70821 </span><span style="font-size: 12pt;"> if you scroll down to "LNL GMD Architecture IDs"</span></div>
<div dir="auto">"</div>
<div dir="auto"><br>
</div>
<div dir="auto">Br</div>
<div dir="auto">Vinod</div>
<div dir="auto"><br>
</div>
<div dir="auto"><br>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Ville Syrjälä <ville.syrjala@linux.intel.com><br>
<b>Sent:</b> Wednesday, September 13, 2023 1:38:23 PM<br>
<b>To:</b> Govindapillai, Vinod <vinod.govindapillai@intel.com><br>
<b>Cc:</b> intel-xe@lists.freedesktop.org <intel-xe@lists.freedesktop.org>; Roper, Matthew D <matthew.d.roper@intel.com>; intel-gfx@lists.freedesktop.org <intel-gfx@lists.freedesktop.org>; Syrjala, Ville <ville.syrjala@intel.com><br>
<b>Subject:</b> Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/lnl: FBC is supported with per pixel alpha</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Mon, Sep 04, 2023 at 02:55:17PM +0300, Vinod Govindapillai wrote:<br>
> For LNL onwards, FBC can be supported on planes with per<br>
> pixel alpha<br>
> <br>
> Bspec: 69560<br>
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com><br>
> ---<br>
> drivers/gpu/drm/i915/display/intel_fbc.c | 3 ++-<br>
> 1 file changed, 2 insertions(+), 1 deletion(-)<br>
> <br>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c<br>
> index a3999ad95a19..c0e4caec03ea 100644<br>
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c<br>
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c<br>
> @@ -1209,7 +1209,8 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,<br>
> return 0;<br>
> }<br>
> <br>
> - if (plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&<br>
> + if (DISPLAY_VER(i915) < 20 &&<br>
<br>
Bspec still says 15. Someone needs to figure this mess out for<br>
all LNL patches.<br>
<br>
> + plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&<br>
> fb->format->has_alpha) {<br>
<br>
We would have already rejected the pixel format earlier, so atm this<br>
check is redundant.<br>
<br>
> plane_state->no_fbc_reason = "per-pixel alpha not supported";<br>
> return 0;<br>
> -- <br>
> 2.34.1<br>
<br>
-- <br>
Ville Syrjälä<br>
Intel<br>
</div>
</span></font></div>
</body>
</html>