<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hey,<br>
</p>
<div class="moz-cite-prefix">Den 2023-11-14 kl. 14:39, skrev Ville
Syrjälä:<br>
</div>
<blockquote type="cite" cite="mid:ZVN4rQjLxROOjTE-@intel.com">
<pre class="moz-quote-pre" wrap="">On Tue, Nov 14, 2023 at 02:35:10PM +0200, Jani Nikula wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">On Tue, 14 Nov 2023, Ville Syrjälä <a class="moz-txt-link-rfc2396E" href="mailto:ville.syrjala@linux.intel.com"><ville.syrjala@linux.intel.com></a> wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">On Mon, Oct 02, 2023 at 09:38:44PM +0200, <a class="moz-txt-link-abbreviated" href="mailto:maarten.lankhorst@linux.intel.com">maarten.lankhorst@linux.intel.com</a> wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">From: Maarten Lankhorst <a class="moz-txt-link-rfc2396E" href="mailto:maarten.lankhorst@linux.intel.com"><maarten.lankhorst@linux.intel.com></a>
Now that we can use -EPROBE_DEFER, it's no longer required to spin off
the snd_hdac_i915_init into a workqueue.
Use the -EPROBE_DEFER mechanism instead, which must be returned in the
probe function.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
This completely broke i915 audio!
I also can't see any trace of this stuff ever being posted to
intel-gfx so it never went through the CI.
Please fix or revert ASAP.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Cc: Jani, Suresh
Ville, please file a bug at gitlab so we can track this, thanks.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
<a class="moz-txt-link-freetext" href="https://gitlab.freedesktop.org/drm/intel/-/issues/9671">https://gitlab.freedesktop.org/drm/intel/-/issues/9671</a></pre>
</blockquote>
<p>Looks like a simple patch should be enough, can you test below?</p>
<p>----<br>
</p>
<pre>diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 058f6e6491f9a..946aaa487f200 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2145,7 +2145,8 @@ static int azx_probe(struct pci_dev *pci,
* for other chips, still continue probing as other
* codecs can be on the same link.
*/
- if (HDA_CONTROLLER_IN_GPU(pci)) {
+ if (HDA_CONTROLLER_IN_GPU(pci) ||
+ err == -EPROBE_DEFER) {
goto out_free;
} else {
/* don't bother any longer */
</pre>
</body>
</html>