<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Calibri;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - AMD Internal Distribution Only]<br>
</p>
<br>
<div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Looks good to me as well, With Christian's comment accommodated: </div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Acked-by: Shashank Sharma <shashank.sharma@amd.com></div>
<div id="appendonsend" style="color: inherit;"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Regards</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Shashank</div>
<hr style="display: inline-block; width: 98%;">
<div dir="ltr" id="divRplyFwdMsg" style="color: inherit;"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> Koenig, Christian <Christian.Koenig@amd.com><br>
<b>Sent:</b> Friday, December 13, 2024 8:34 AM<br>
<b>To:</b> André Almeida <andrealmeid@igalia.com>; Raag Jadav <raag.jadav@intel.com>; airlied@gmail.com <airlied@gmail.com>; simona@ffwll.ch <simona@ffwll.ch>; lucas.demarchi@intel.com <lucas.demarchi@intel.com>; rodrigo.vivi@intel.com <rodrigo.vivi@intel.com>;
jani.nikula@linux.intel.com <jani.nikula@linux.intel.com>; andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com>; lina@asahilina.net <lina@asahilina.net>; michal.wajdeczko@intel.com <michal.wajdeczko@intel.com>; Sharma, Shashank <Shashank.Sharma@amd.com><br>
<b>Cc:</b> intel-gfx@lists.freedesktop.org <intel-gfx@lists.freedesktop.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; himal.prasad.ghimiray@intel.com <himal.prasad.ghimiray@intel.com>; aravind.iddamsetty@linux.intel.com <aravind.iddamsetty@linux.intel.com>;
anshuman.gupta@intel.com <anshuman.gupta@intel.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; kernel-dev@igalia.com <kernel-dev@igalia.com><br>
<b>Subject:</b> Re: [PATCH 1/1] drm/amdgpu: Use device wedged event</span>
<div> </div>
</div>
<div style="font-size: 11pt;">Am 12.12.24 um 20:09 schrieb André Almeida:<br>
> Use DRM's device wedged event to notify userspace that a reset had<br>
> happened. For now, only use `none` method meant for telemetry<br>
> capture.<br>
><br>
> Signed-off-by: André Almeida <andrealmeid@igalia.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++<br>
> 1 file changed, 3 insertions(+)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
> index 96316111300a..19e1a5493778 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
> @@ -6057,6 +6057,9 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,<br>
> dev_info(adev->dev, "GPU reset end with ret = %d\n", r);<br>
> <br>
> atomic_set(&adev->reset_domain->reset_res, r);<br>
> +<br>
> + drm_dev_wedged_event(adev_to_drm(adev), DRM_WEDGE_RECOVERY_NONE);<br>
<br>
That looks really good in general. I would just make the<br>
DRM_WEDGE_RECOVERY_NONE depend on the value of "r".<br>
<br>
@Shashank any objections? IIRC you have worked on the AMD specific event<br>
we never upstreamed.<br>
<br>
Regards,<br>
Christian.<br>
<br>
> +<br>
> return r;<br>
> }<br>
> <br>
<br>
</div>
</div>
</body>
</html>