<!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> Hi, My inline comments <div class="moz-cite-prefix">On 12/18/2024 2:07 AM, Bhadane, Dnyaneshwar wrote: </div> <blockquote type="cite" cite="mid:IA1PR11MB62660FE4E97DE8DA25233221E2042@IA1PR11MB6266.namprd11.prod.outlook.com"> <pre wrap="" class="moz-quote-pre"> </pre> <blockquote type="cite"> <pre wrap="" class="moz-quote-pre">-----Original Message----- From: Vodapalli, Ravi Kumar <a class="moz-txt-link-rfc2396E" href="mailto:ravi.kumar.vodapalli@intel.com"><ravi.kumar.vodapalli@intel.com></a> Sent: Tuesday, December 17, 2024 11:00 PM To: <a class="moz-txt-link-abbreviated" href="mailto:intel-gfx@lists.freedesktop.org">intel-gfx@lists.freedesktop.org</a> Cc: Vivekanandan, Balasubramani <a class="moz-txt-link-rfc2396E" href="mailto:balasubramani.vivekanandan@intel.com"><balasubramani.vivekanandan@intel.com></a>; Roper, Matthew D <a class="moz-txt-link-rfc2396E" href="mailto:matthew.d.roper@intel.com"><matthew.d.roper@intel.com></a>; De Marchi, Lucas <a class="moz-txt-link-rfc2396E" href="mailto:lucas.demarchi@intel.com"><lucas.demarchi@intel.com></a>; Sousa, Gustavo <a class="moz-txt-link-rfc2396E" href="mailto:gustavo.sousa@intel.com"><gustavo.sousa@intel.com></a>; Taylor, Clinton A <a class="moz-txt-link-rfc2396E" href="mailto:clinton.a.taylor@intel.com"><clinton.a.taylor@intel.com></a>; Atwood, Matthew S <a class="moz-txt-link-rfc2396E" href="mailto:matthew.s.atwood@intel.com"><matthew.s.atwood@intel.com></a>; Bhadane, Dnyaneshwar <a class="moz-txt-link-rfc2396E" href="mailto:dnyaneshwar.bhadane@intel.com"><dnyaneshwar.bhadane@intel.com></a>; Kalvala, Haridhar <a class="moz-txt-link-rfc2396E" href="mailto:haridhar.kalvala@intel.com"><haridhar.kalvala@intel.com></a>; Chauhan, Shekhar <a class="moz-txt-link-rfc2396E" href="mailto:shekhar.chauhan@intel.com"><shekhar.chauhan@intel.com></a> Subject: [PATCH] drm/i915/display: Don't program DBUF_CTL tracker state service While display initialization along with MBUS credits programming DBUF_CTL register is also programmed, as a part of it the tracker state service field is also set to 0x8 value when default value is other than 0x8 which are for platforms past display version 13. For remaining platforms the default value is already 0x8 so don't program them. Bspec: 49213 Signed-off-by: Ravi Kumar Vodapalli <a class="moz-txt-link-rfc2396E" href="mailto:ravi.kumar.vodapalli@intel.com"><ravi.kumar.vodapalli@intel.com></a> --- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c index 34465d56def0..cbcc4bddc01f 100644 --- a/drivers/gpu/drm/i915/display/intel_display_power.c +++ b/drivers/gpu/drm/i915/display/intel_display_power.c @@ -1126,7 +1126,7 @@ static void gen12_dbuf_slices_config(struct intel_display *display) { enum dbuf_slice slice; - if (display->platform.alderlake_p) + if (DISPLAY_VER(display) >= 13) </pre> </blockquote> <pre wrap="" class="moz-quote-pre">Hi Ravi, This new condition is not needed here since there's already a similar check in the caller function icl_display_core_init(). Please update the condition at the caller function and remove this code from here. </pre> </blockquote> As MattR explained The function gen12_dbuf_slices_config() name suggest that it is called for gen12 platform onwards and higher, any changes in the code for higher platforms has to be implemented in that function. Ravi Kumar V <blockquote type="cite" cite="mid:IA1PR11MB62660FE4E97DE8DA25233221E2042@IA1PR11MB6266.namprd11.prod.outlook.com"> <pre wrap="" class="moz-quote-pre"> Dnyaneshwar, </pre> <blockquote type="cite"> <pre wrap="" class="moz-quote-pre"> return; for_each_dbuf_slice(display, slice) -- 2.25.1 </pre> </blockquote> <pre wrap="" class="moz-quote-pre"> </pre> </blockquote> </body> </html>