<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Fri, Jun 20, 2025 at 8:47 AM Sean Paul <<a href="mailto:seanpaul@chromium.org">seanpaul@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, Apr 3, 2025 at 9:48 AM Jim Cromie <<a href="mailto:jim.cromie@gmail.com" target="_blank">jim.cromie@gmail.com</a>> wrote:<br>
><br>
<br>
\snip<br>
<br>
><br>
> -static void ddebug_match_apply_kparam(const struct kernel_param *kp,<br>
> -                                     const struct _ddebug_class_map *map,<br>
> -                                     const char *mod_name)<br>
> +static struct _ddebug_class_param *<br>
> +ddebug_get_classmap_kparam(const struct kernel_param *kp,<br>
> +                          const struct _ddebug_class_map *map)<br>
>  {<br>
>         struct _ddebug_class_param *dcp;<br>
><br>
>         if (kp->ops != &param_ops_dyndbg_classes)<br>
> -               return;<br>
> +               return false;<br>
<br>
Return type is struct _ddebug_class_param *, should this be NULL?<br>
<br></blockquote><div><br></div><div>yes it should. thx.  will revise</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
</blockquote></div></div>