[PATCH 1/2] drm/i915/gvt: change resetting to resetting_eng

[Dong, Chuanxiao]

> -----Original Message-----
> From: Zhenyu Wang [mailto:zhenyuw at linux.intel.com]
> Sent: Tuesday, August 1, 2017 4:10 PM
> To: Dong, Chuanxiao <chuanxiao.dong at intel.com>
> Cc: intel-gvt-dev at lists.freedesktop.org
> Subject: Re: [PATCH 1/2] drm/i915/gvt: change resetting to resetting_eng
> 
> On 2017.08.01 14:23:55 +0800, Chuanxiao Dong wrote:
> > Use resetting_eng to identify which engine is resetting so the rest
> > ones' workload won't be impacted
> >
> > Signed-off-by: Chuanxiao Dong <chuanxiao.dong at intel.com>
> > ---
> >  drivers/gpu/drm/i915/gvt/execlist.c  | 10 +++++-----
> >  drivers/gpu/drm/i915/gvt/gvt.h       |  2 +-
> >  drivers/gpu/drm/i915/gvt/scheduler.c |  3 ++-
> >  drivers/gpu/drm/i915/gvt/vgpu.c      |  8 +++++---
> >  4 files changed, 13 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/execlist.c
> > b/drivers/gpu/drm/i915/gvt/execlist.c
> > index 3380865..a0b81a2 100644
> > --- a/drivers/gpu/drm/i915/gvt/execlist.c
> > +++ b/drivers/gpu/drm/i915/gvt/execlist.c
> > @@ -499,10 +499,10 @@ static void release_shadow_wa_ctx(struct
> > intel_shadow_wa_ctx *wa_ctx)  static int
> > complete_execlist_workload(struct intel_vgpu_workload *workload)  {
> >  	struct intel_vgpu *vgpu = workload->vgpu;
> > -	struct intel_vgpu_execlist *execlist =
> > -		&vgpu->execlist[workload->ring_id];
> > +	int ring_id = workload->ring_id;
> > +	struct intel_vgpu_execlist *execlist = &vgpu->execlist[ring_id];
> >  	struct intel_vgpu_workload *next_workload;
> > -	struct list_head *next = workload_q_head(vgpu, workload->ring_id)-
> >next;
> > +	struct list_head *next = workload_q_head(vgpu, ring_id)->next;
> >  	bool lite_restore = false;
> >  	int ret;
> >
> > @@ -512,10 +512,10 @@ static int complete_execlist_workload(struct
> intel_vgpu_workload *workload)
> >  	release_shadow_batch_buffer(workload);
> >  	release_shadow_wa_ctx(&workload->wa_ctx);
> >
> > -	if (workload->status || vgpu->resetting)
> > +	if (workload->status || (vgpu->resetting_eng & (1 << ring_id)))
> 
> Let's use ENGINE_MASK(ring_id), ditto later parts and next one.
> Others seem fine to me. Thanks.

Sure. Will switch to this and send out v2.

Thanks
Chuanxiao

> 
> --
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827