[PATCH] drm/i915/gvt: Fix the kernel null pointer error

[Zhenyu Wang]

On 2017.08.15 15:16:55 +0800, fred gao wrote:
> once error happens in shadow_indirect_ctx function, the variable
> wa_ctx->indirect_ctx.obj is not initialized but accessed, so the
> kernel null point panic occurs.
> 
> Signed-off-by: fred gao <fred.gao at intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index 23a9bbb..2c0ccbb 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -2725,7 +2725,7 @@ static int shadow_indirect_ctx(struct intel_shadow_wa_ctx *wa_ctx)
>  unmap_src:
>  	i915_gem_object_unpin_map(obj);
>  put_obj:
> -	i915_gem_object_put(wa_ctx->indirect_ctx.obj);
> +	i915_gem_object_put(obj);
>  	return ret;
>  }
>  

Good catch. We need to cc stable too for this.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20170816/8dbf8e58/attachment.sig>