[PATCH v3] drm/i915/gvt: introduced failsafe mode into vgpu

Zhenyu Wang zhenyuw at linux.intel.com
Thu Feb 16 10:46:12 UTC 2017


On 2017.02.16 18:19:19 +0800, He, Min wrote:
> > > +static void enter_failsafe_mode(struct intel_vgpu *vgpu, int reason)
> > > +{
> > > +	switch (reason) {
> > > +	case UNSUPPORTED_GUESTS:
> > > +		pr_err("Detected your guest driver doesn't support GVT-g.\n");
> > > +		pr_err("Please update your guest graphics driver.\n");
> > > +		break;
> > > +	default:
> > > +		break;
> > > +	}
> > > +	pr_err("Now vgpu %d will enter failsafe mode.\n", vgpu->id);
> > > +	pr_err("You may need to kill your guest manually.\n");
> > a little too chatty, can remove second line for both above messages.
> If we don't output enough message, customer cannot know what's the next step
> and how to handle this kind of issue.
> At least we need to document it in somewhere else, for example in the
> wiki/usre guide.
> 

Well, we were complained about too chatty driver message before as
kernel has already been bloat for too many messages if that
message doesn't provide meaningful info, so be careful.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20170216/9202789c/attachment-0001.sig>


More information about the intel-gvt-dev mailing list