[PATCH] drm/i915/gvt: add cmd_access flag for 2 MMIO to avoid log flood

Zhenyu Wang zhenyuw at linux.intel.com
Fri Feb 17 05:28:05 UTC 2017


On 2017.02.17 19:29:48 +0800, Pei Zhang wrote:
> If guest is accessing an un-expected mmio through cmd, gvt will print an
> error log. In some special case, the guest cmd access of such mmio is
> very huge which cause the error log flood. Add F_CMD_ACCESS flag to 2 new
> found mmio to avoid log flood.
>

I think you should emphasize this to fix missed flag for those
registers as user could cmd accesss, as logging issue is just side
effect but not the root issue. Pls fix commit message then I'll
apply. Thanks.

> Signed-off-by: Pei Zhang <pei.zhang at intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/handlers.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
> index f8a2927..48176b3 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -2175,7 +2175,8 @@ static int init_generic_mmio_info(struct intel_gvt *gvt)
>  
>  	MMIO_D(0x44070, D_ALL);
>  
> -	MMIO_D(0x215c, D_HSW_PLUS);
> +	MMIO_DFH(0x215c, D_HSW_PLUS, F_CMD_ACCESS, NULL, NULL);
> +	MMIO_DFH(0x20c0, D_HSW_PLUS, F_CMD_ACCESS, NULL, NULL);
>  	MMIO_DFH(0x120c0, D_HSW_PLUS, F_CMD_ACCESS, NULL, NULL);
>  	MMIO_DFH(0x220c0, D_HSW_PLUS, F_CMD_ACCESS, NULL, NULL);
>  	MMIO_DFH(0x2178, D_ALL, F_CMD_ACCESS, NULL, NULL);
> -- 
> 2.7.4
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gvt-dev/attachments/20170217/1e472883/attachment.sig>


More information about the intel-gvt-dev mailing list